Change Harness::run to run until no more repaints are requested
#5580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmerlin
added
feature
|
Preview available at https://egui-pr-preview.github.io/pr/5580-lucaskittest-run-until-no-more-repaints |
lucasmerlin
commented
Jan 3, 2025
lucasmerlin
commented
Jan 3, 2025
emilk
reviewed
Jan 6, 2025
lucasmerlin
force-pushed
the
lucas/kittest-run-until-no-more-repaints
branch
from
5cd20ef to
51facca
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Harness::runjust calledHarness::step3 times. If that wasn't enough, tests would often call run multiple times so all animations would finish properly.Also, I introduced
HarnessBuilder::with_step_dtto customize with how big of a dt each frame is called. I set the default to 1.0 / 6.0 (~6fps) so we don't waste cpu in tests waiting on animations.HarnessBuilder::max_stepsallows us to control how many stepsHarness::runshould run before panicing.The default is 6, so we run for up to 1.0 logical seconds (six frames at 6 fps), which should be enough to finish most animations.
Turns out a lot of snapshots where rendered before fully shown and had a light opacity, those are now fixed.