Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ci pipeline #235

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Fix Ci pipeline #235

merged 3 commits into from
Nov 24, 2023

Conversation

manumerous
Copy link
Contributor

Removed depreciated make install-full-dependencies since the vpselector is not just a pip package in requirements.txt

@manumerous manumerous changed the title Fix Ci pipeline [WIP] Fix Ci pipeline Nov 23, 2023
@manumerous
Copy link
Contributor Author

It seems to be a timeout issue. Could be that the runner is running out of memory or a timeout is triggered. Have to investigate further. The same step works locally for me and @sjschlapbach the local dependencies installation worked.

@manumerous
Copy link
Contributor Author

@Jaeyoung-Lim do we have access to some asl runners?

@Jaeyoung-Lim
Copy link
Member

@manumerous Interesting, although the asl runners would have even less memory.

@manumerous
Copy link
Contributor Author

It is just a suspicion my now. In the pipeline there is no obvious fail, the script is just terminated 🤔

@Jaeyoung-Lim
Copy link
Member

@manumerous
Copy link
Contributor Author

Checked for the CI timeout. it is set to 45 min. So I doubt that was the issue. I think it was likely a memory issue due to us installing more dependencies through the vpselector (especially pyqt is heavy). Switching to the custom ASL runner seems to solve this issue.

@manumerous manumerous changed the title [WIP] Fix Ci pipeline Fix Ci pipeline Nov 24, 2023
@manumerous manumerous requested review from pascalau, Jaeyoung-Lim and sjschlapbach and removed request for pascalau November 24, 2023 07:26
@manumerous
Copy link
Contributor Author

Please go ahead and merge directly if you agree with the changes.

Copy link
Collaborator

@sjschlapbach sjschlapbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for fixing the pipeline!

@Jaeyoung-Lim Jaeyoung-Lim merged commit 252a9cb into master Nov 24, 2023
4 checks passed
@Jaeyoung-Lim Jaeyoung-Lim deleted the fix/ci-pipeline branch November 24, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants