Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hover on cart button #50

Merged
merged 2 commits into from
Dec 19, 2023
Merged

add hover on cart button #50

merged 2 commits into from
Dec 19, 2023

Conversation

OlhaKoziuk
Copy link
Contributor

vlevik
vlevik approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@vlevik vlevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mpohorenyi
mpohorenyi approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mpohorenyi mpohorenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

dsfreedom
dsfreedom approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@dsfreedom dsfreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code.)

src/modules/CartPage/CartPage.module.scss Outdated

&__DARK {
border-radius: 0;
color: $color__dark-theme__white;
background-color: $color__dark-theme__accent;
}

&__DARK:hover {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just write inside &__DARK &:hover and it will work nicely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean. Could you please provide an example for clarification?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&__DARK:hover {
&__DARK {
border-radius: 0;
color: $color__dark-theme__white;
background-color: $color__dark-theme__accent;
&:hover {
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One moment)

@OlhaKoziuk OlhaKoziuk merged commit 6ec1016 into master Dec 19, 2023
1 check passed
@mpohorenyi mpohorenyi deleted the cart-add-hover branch December 27, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpohorenyi mpohorenyi mpohorenyi approved these changes

@vlevik vlevik vlevik approved these changes

@dsfreedom dsfreedom dsfreedom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OlhaKoziuk @dsfreedom @mpohorenyi @vlevik