Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hover on cart button #50

Merged
merged 2 commits into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/modules/CartPage/CartPage.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,22 @@
color: $color__white;
@include buttons-typography;
background-color: $color__accent;
cursor: pointer;
transition: all 0.3s ease;

&:hover {
box-shadow: 0px 3px 13px 0px rgba(23, 32, 49, 0.40);
}

&__DARK {
border-radius: 0;
color: $color__dark-theme__white;
background-color: $color__dark-theme__accent;
}

&__DARK:hover {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just write inside &__DARK &:hover and it will work nicely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you mean. Could you please provide an example for clarification?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
&__DARK:hover {
&__DARK {
border-radius: 0;
color: $color__dark-theme__white;
background-color: $color__dark-theme__accent;
&:hover {
}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One moment)

background-color: $color__dark-theme__accent__hover;
}
}

.contentDark {
Expand Down
43 changes: 22 additions & 21 deletions src/styles/utils/variables/_colors.scss
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
// Bright theme
$color__accent: #f86800;
$color__secondary-accent: #476df4;
$color__primary: #0f0f11;
$color__secondary: #89939a;
$color__icons: #b4bdc3;
$color__elements: #e2e6e9;
$color__hover-and-bg: #fafbfc;
$color__white: #ffffff;
$color__green: #27ae60;
$color__red: #eb5757;

// Dark theme
$color__dark-theme__secondary: #75767f;
$color__dark-theme__icons: #4a4d58;
$color__dark-theme__elements: #3b3e4a;
$color__dark-theme__surface-1: #161827;
$color__dark-theme__surface-2: #323542;
$color__dark-theme__black: #0f1121;
$color__dark-theme__white: #f1f2f9;
$color__dark-theme__accent: #905bff;
// Bright theme
$color__accent: #f86800;
$color__secondary-accent: #476df4;
$color__primary: #0f0f11;
$color__secondary: #89939a;
$color__icons: #b4bdc3;
$color__elements: #e2e6e9;
$color__hover-and-bg: #fafbfc;
$color__white: #ffffff;
$color__green: #27ae60;
$color__red: #eb5757;

// Dark theme
$color__dark-theme__secondary: #75767f;
$color__dark-theme__icons: #4a4d58;
$color__dark-theme__elements: #3b3e4a;
$color__dark-theme__surface-1: #161827;
$color__dark-theme__surface-2: #323542;
$color__dark-theme__black: #0f1121;
$color__dark-theme__white: #f1f2f9;
$color__dark-theme__accent: #905bff;
$color__dark-theme__accent__hover: #a378ff;