Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project to be a normal ROS package #33

Merged
merged 32 commits into from
May 12, 2024

Conversation

felixdivo
Copy link
Owner

@felixdivo felixdivo commented Apr 12, 2024

This was required for #23 / ros/rosdistro#39892.

It also switches from black to ruff format and activates two previously broken test cases. Also restores installability on CI for ROS Rolling.

@felixdivo felixdivo self-assigned this Apr 12, 2024
@felixdivo
Copy link
Owner Author

I don't really understand how to fix the error here: https://github.com/felixdivo/ros2-easy-test/actions/runs/8659687762/job/23746089747?pr=33 ...

@felixdivo felixdivo added the enhancement New feature or request label Apr 12, 2024
@Timple
Copy link
Contributor

Timple commented Apr 12, 2024

Perhaps because extras_require lists a lot of dependencies. These will (but shouldn't be) pip installed?

I would actually just pick one release method. Remove all pip related stuff and create a nice ros package.

.github/workflows/python-package.yaml Outdated Show resolved Hide resolved
.github/workflows/python-package.yaml Outdated Show resolved Hide resolved
.github/workflows/python-package.yaml Outdated Show resolved Hide resolved
@felixdivo felixdivo mentioned this pull request Apr 30, 2024
@felixdivo felixdivo force-pushed the move-to-normal-ros-package branch from 100f97e to f027f81 Compare May 5, 2024 12:05
@felixdivo
Copy link
Owner Author

Well, pip is still required to install makefun (sadly not available via package.xml/Ros Index). But aside from that, installing it for normal usage works without it. Installing for development needs more dependencies, so there you'd still require pip.

@felixdivo felixdivo added maintenance Keeping things going, getting rid of technical debt and removed enhancement New feature or request labels May 11, 2024
@felixdivo felixdivo force-pushed the move-to-normal-ros-package branch from cee5bb1 to b8ddab3 Compare May 12, 2024 00:03
@felixdivo felixdivo merged commit 597e617 into main May 12, 2024
2 of 3 checks passed
@felixdivo felixdivo deleted the move-to-normal-ros-package branch May 12, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Keeping things going, getting rid of technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants