Adding the ability to install libsimulate library and associated headers during installation. #2170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saran-t
reviewed
Oct 30, 2024
saran-t
reviewed
Oct 30, 2024
saran-t
reviewed
Oct 30, 2024
|
|
||
| message(STATUS "lolwaGLFW3 Source Directory: ${glfw3_SOURCE_DIR}") | ||
|
|
||
| # Install GLFW headers if not using system GLFW |
There was a problem hiding this comment.
I don't like this at all since we'd be vendoring other project's headers as part of the install.
If the GLFW headers are needed then you should just set USE_SYSTEM_GLFW.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim
I want to use the libsimulate header in my internal simulator. I want to leverage the default mujoco visualizer instead of writing my own. Wanted to add the ability to install the libsimulate and headers in my dev container directly from CMake.