Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pyroscope.receive_http): Handle metrics registry gracefully #2302

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix(pyroscope.receive_http): Handle metrics registry gracefully #2302

merged 1 commit into from
Dec 19, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Dec 19, 2024 •
edited
Loading

This component did not handle duplciate registrations well, esp. when the server was restarted.

This fixes bug report #2285.

@simonswine
fix(pyroscope.receive_http): Handle metrics registry gracefully
181585b 
This component did not handle duplciate registrations well.

This fixes grafana#2285.
@simonswine simonswine marked this pull request as ready for review December 19, 2024 15:26
@simonswine simonswine requested a review from a team as a code owner December 19, 2024 15:26
@simonswine simonswine added bug Something isn't working backport release/v1.5 labels Dec 19, 2024
marcsanmi
marcsanmi approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@marcsanmi marcsanmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing it 👍

@simonswine simonswine merged commit 2b42ec4 into grafana:main Dec 19, 2024
17 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
@simonswine @grafanabot
fix(pyroscope.receive_http): Handle metrics registry gracefully (#2302)
fb792cf 
This component did not handle duplciate registrations well.

This fixes #2285.

(cherry picked from commit 2b42ec4)
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
Merged
simonswine added a commit that referenced this pull request Dec 19, 2024
@github-actions @simonswine
fix(pyroscope.receive_http): Handle metrics registry gracefully (#2302)…
2594b77 
… (#2303)

This component did not handle duplciate registrations well.

This fixes #2285.

(cherry picked from commit 2b42ec4)

Co-authored-by: Christian Simon <simon@swine.de>
@marcsanmi marcsanmi mentioned this pull request Jan 8, 2025
Closed
@wildum
Copy link
Contributor

wildum commented Jan 8, 2025

thanks for fixing the bug, please add changelog entries in the future (https://github.com/grafana/alloy/blob/main/CHANGELOG.md).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcsanmi marcsanmi marcsanmi approved these changes

Assignees
No one assigned
Labels
backport release/v1.5 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonswine @wildum @marcsanmi