Handle crossword articles #12925
Merged
Handle crossword articles #12925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12.7 kB (+1.45%) Total Size: 883 kB
ℹ️ View Unchanged
|
sndrs
force-pushed
the
e2e/add-react-crossword
branch
from
0789e74 to
8a244f7
Compare
sndrs
force-pushed
the
e2e/add-react-crossword
branch
from
2e7e45f to
3fe07f7
Compare
sndrs
requested review from
oliverabrahams and
JamieB-gu
and removed request for
a team
JamieB-gu
reviewed
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
sndrs
commented
Dec 11, 2024
github-actions
bot
added
apps-rendering
and removed
run_chromatic
this is a first pass, it needs work
github-actions
bot
removed
the
run_chromatic
JamieB-gu
reviewed
Dec 13, 2024
# Conflicts: # dotcom-rendering/src/types/content.ts # dotcom-rendering/src/types/frontend.ts
…s and out of handle.article.web
arelra
approved these changes
Jan 16, 2025
| @@ -50,6 +50,7 @@ | |||
| "@guardian/libs": "19.2.1", | |||
| "@guardian/ophan-tracker-js": "2.2.5", | |||
| "@guardian/react-crossword": "2.0.2", | |||
| "@guardian/react-crossword-next": "npm:@guardian/react-crossword@0.0.0-canary-20250114144251", | |||
There was a problem hiding this comment.
Would be preferable to use a release version rather than a canary, particularly before we move to a >0% size test.
| @@ -126,6 +127,7 @@ export interface FEArticleType { | |||
| showTableOfContents: boolean; | |||
| lang?: string; | |||
| isRightToLeftLang?: boolean; | |||
| crossword?: CrosswordProps['data']; | |||
There was a problem hiding this comment.
This is a larger point but I was surprised to see crossword as its own top-level property of the Frontend data model rather than as standard 'block'.
Something we can rationalise as it would mean we don't have to parse out the data separately in the enhancers and can treat as any other element type?
Co-authored-by: Oliver Abrahams <ollie.abrahams@guardian.co.uk>
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (created by @sndrs and merged by @oliverabrahams 7 minutes and 43 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based heavily on the work done by @andrew-nowak in #12511, this is first pass of getting crosswords working in DCR.
it does not include layout changes, because there's work to be done in CAPI client and frontend to support that.
those will come in #13001.