Add crossword layout #13001
Open
Add crossword layout #13001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a first pass, it needs work
and use JSdoc for editor assistance
This reverts commit f3b9feb.
|
Size Change: +1.11 kB (+0.13%) Total Size: 885 kB
ℹ️ View Unchanged
|
Merged
SiAdcock
reviewed
Jan 10, 2025
# Conflicts: # dotcom-rendering/src/types/content.ts # dotcom-rendering/src/types/frontend.ts
…s and out of handle.article.web
# Conflicts: # dotcom-rendering/package.json # dotcom-rendering/src/components/Crossword.importable.tsx # dotcom-rendering/src/lib/articleFormat.ts # dotcom-rendering/src/types/article.ts # pnpm-lock.yaml
…ct-crossword - update lockfile
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
arelra
reviewed
Jan 16, 2025
| @@ -160,6 +161,10 @@ const getRenderedTokens = ( | |||
| ); | |||
| } | |||
|
|
|||
| if (design === ArticleDesign.Crossword && renderedTokens.length > 0) { | |||
| return [<Fragment key="set-by">Set by: </Fragment>, ...renderedTokens]; | |||
There was a problem hiding this comment.
Its not clear why we need this Fragment? Also keys are normally used to set a unique identifier for items in a list so not sure about the use case here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP of a crossword-specific layout.
requires #12925. also, a lot of this may be taken care of by #13083.