-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Remove BlockMatrix persist from Backend interface #14690
Open
ehigham
wants to merge
1
commit into
ehigham/ctx-references
Choose a base branch
from
ehigham/ctx-bm-cache
base: ehigham/ctx-references
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 17, 2024
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 17, 2024
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
September 19, 2024 20:52
92da6f0
to
4576acf
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
September 19, 2024 20:52
b0be25e
to
6038f9b
Compare
This was referenced Sep 20, 2024
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 1, 2024 19:44
4576acf
to
8a42e93
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
2 times, most recently
from
October 1, 2024 20:03
15f2275
to
71fcb35
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 8, 2024 19:18
341e6a7
to
1682964
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 8, 2024 19:18
71fcb35
to
360af7c
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 8, 2024 20:30
1682964
to
b1c0d04
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 8, 2024 20:30
360af7c
to
d16f9c6
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 16, 2024 20:02
b1c0d04
to
84ddcf3
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 16, 2024 20:02
d16f9c6
to
783df28
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 16, 2024 21:30
84ddcf3
to
a2ff477
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 16, 2024 21:30
783df28
to
7e661e4
Compare
1 task
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 17, 2024 14:59
a2ff477
to
df5c723
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 17, 2024 15:00
7e661e4
to
952b01d
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 21, 2024 15:24
df5c723
to
adc0602
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
October 21, 2024 15:24
952b01d
to
a265389
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
October 21, 2024 18:50
adc0602
to
24b20f3
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 12, 2024 22:02
92087ca
to
d7df668
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
December 12, 2024 22:02
6c61a48
to
e115c2c
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 16, 2024 18:49
d7df668
to
a33bb7f
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
December 16, 2024 18:49
e115c2c
to
c834eaf
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 17, 2024 16:47
a33bb7f
to
b19073d
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
December 17, 2024 16:47
c834eaf
to
0d9d8f3
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
December 17, 2024 20:00
b19073d
to
75f4fd5
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
2 times, most recently
from
December 17, 2024 20:28
531890c
to
a7f6c50
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 13, 2025 16:36
75f4fd5
to
5c0308f
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
January 13, 2025 16:36
a7f6c50
to
96e508a
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 17, 2025 21:15
5c0308f
to
90a9649
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
January 17, 2025 21:15
96e508a
to
f23b4f2
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 21, 2025 16:48
90a9649
to
ff175f0
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
January 21, 2025 16:48
f23b4f2
to
7949c41
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 21, 2025 20:14
ff175f0
to
f1a3197
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
January 21, 2025 20:15
7949c41
to
85f3e21
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 21, 2025 21:02
f1a3197
to
482d085
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
2 times, most recently
from
January 22, 2025 15:50
8fe9826
to
35728c2
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 22, 2025 16:45
482d085
to
901fafe
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
2 times, most recently
from
January 22, 2025 17:30
8ddcb28
to
c5b8c2d
Compare
1 task
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 24, 2025 20:54
901fafe
to
7c3af40
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
January 24, 2025 20:54
c5b8c2d
to
574082e
Compare
ehigham
force-pushed
the
ehigham/ctx-references
branch
from
January 27, 2025 23:15
7c3af40
to
dd052e7
Compare
ehigham
force-pushed
the
ehigham/ctx-bm-cache
branch
from
January 27, 2025 23:15
574082e
to
2749402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is split out from a larger refactoring effort on the various Backend
implementations. The goals of this effort are to provide query-level
configuration to the backend that's currently tied to the lifetime of a backend,
reduce code duplication and reduce state duplication.
In this change, I'm removing blockmatrix persist/unpersist from the
Backend
interface by adding
BlockMatrixCache: mutable.Map[String, BlockMatrix]
toExecuteContext
. The various reader/writer implementations simply fetch theblock matrix from this cache. For the spark backend, this is backed by a cache
whose lifetime is tied to the spark backend. Since block matrices are not
supported in the local and service backends, the cache is an empty map.
Note that block matrix persist is broken in python (#14689)