Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] unify backend rpc #14693

Open
wants to merge 1 commit into
base: ehigham/ctx-persisted-ir
Choose a base branch
from
Open

[query] unify backend rpc #14693

wants to merge 1 commit into from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 18, 2024

No description provided.

@ehigham ehigham marked this pull request as ready for review September 18, 2024 20:47
@ehigham ehigham mentioned this pull request Sep 18, 2024
Merged
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 6a03bb4 to 99e06b5 Compare September 18, 2024 21:07
This was referenced Sep 19, 2024
Merged
Open
Open
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 99e06b5 to 9283b9c Compare September 19, 2024 20:51
@ehigham ehigham mentioned this pull request Sep 19, 2024
Open
@ehigham Graphite App
Copy link
Member Author

ehigham commented Sep 19, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ehigham ehigham mentioned this pull request Sep 19, 2024
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 40cfdd1 to 8ac34e8 Compare September 19, 2024 20:53
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 9283b9c to 7d91073 Compare September 19, 2024 20:53
ehigham
ehigham commented Sep 19, 2024
View reviewed changes
hail/python/hail/backend/py4j_backend.py

def _parse_matrix_ir(self, code):
return self._jbackend.parse_matrix_ir(code)

def _parse_blockmatrix_ir(self, code):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still used to compute blockmatrix sparsity. All others were just used in tests to test that irs parse (which is done by the _type methods)
I wonder if we can move sparsity into the block matrix type and then this too can be removed?

This was referenced Sep 20, 2024
Open
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 8ac34e8 to 956e751 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from f2c39a6 to 2f3f122 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 956e751 to c07ff10 Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2f3f122 to b02c83b Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from c07ff10 to e7782e2 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from b02c83b to 20e6520 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from e7782e2 to 7969e05 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 20e6520 to e66b858 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 7969e05 to 1142a0d Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from e66b858 to 49bdf73 Compare October 16, 2024 20:02
@ehigham ehigham mentioned this pull request Oct 16, 2024
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 1142a0d to cf4fa39 Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 49bdf73 to 0ce4a09 Compare October 16, 2024 21:30
@ehigham ehigham mentioned this pull request Oct 17, 2024
Closed
1 task
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 053a62b to c9a1cc5 Compare October 30, 2024 22:27
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from bc035dc to 5a61217 Compare October 31, 2024 15:47
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from c9a1cc5 to 51f8702 Compare October 31, 2024 15:48
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 5a61217 to 8b2b5cc Compare November 4, 2024 22:15
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 51f8702 to cbe8467 Compare November 4, 2024 22:15
@ehigham ehigham mentioned this pull request Nov 14, 2024
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 8b2b5cc to 9438e05 Compare November 19, 2024 17:08
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cbe8467 to cc56f09 Compare November 19, 2024 17:08
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 9438e05 to 90dda0d Compare November 20, 2024 17:00
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cc56f09 to 6bd3033 Compare November 20, 2024 17:01
This was referenced Dec 5, 2024
Open
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 90dda0d to cf73955 Compare December 12, 2024 21:51
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 6bd3033 to 59ad7bb Compare December 12, 2024 21:51
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from cf73955 to f9af4df Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 59ad7bb to 1408798 Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from f9af4df to 969c75d Compare December 12, 2024 22:02
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 1408798 to cb9b39e Compare December 12, 2024 22:02
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 969c75d to 9d0348e Compare December 16, 2024 18:49
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from cb9b39e to fcf6c67 Compare December 16, 2024 18:49
@ehigham ehigham mentioned this pull request Dec 16, 2024
Open
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 9d0348e to a096c67 Compare December 17, 2024 16:48
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from fcf6c67 to fc4afd0 Compare December 17, 2024 16:48
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from a096c67 to 9b61a9b Compare December 17, 2024 20:00
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from fc4afd0 to 2941b77 Compare December 17, 2024 20:00
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 9b61a9b to bfa84f0 Compare December 17, 2024 20:28
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2941b77 to 25101f4 Compare December 17, 2024 20:29
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from bfa84f0 to a4febcb Compare January 13, 2025 16:36
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 25101f4 to 5300b18 Compare January 13, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ehigham