Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't hardcode paths to test resources #14775

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

patrick-schultz
Copy link
Collaborator

@patrick-schultz patrick-schultz commented Jan 7, 2025

Change Description

Factor out the location of the test resources directory in the scala tests, so we only need to change one place when we rearrange the directory structure.

Security Assessment

  • This change has no security impact

Impact Description

Tests only

Copy link
Collaborator Author

patrick-schultz commented Jan 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@patrick-schultz patrick-schultz force-pushed the ps/scala-test-resource-paths branch from 7f1e1d2 to 1e5dc96 Compare January 7, 2025 17:13
Copy link
Collaborator

@cjllanwarne cjllanwarne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great improvement over copying and pasting the same predetermined value in multiple places.

Copy link
Contributor

@grohli grohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hail-ci-robot hail-ci-robot merged commit ba7e79d into main Jan 7, 2025
3 checks passed
@hail-ci-robot hail-ci-robot deleted the ps/scala-test-resource-paths branch January 7, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants