Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-105, H-3342: Move workspace to error-stack v0.6 #5200

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

indietyp
Copy link
Member

🌟 What is the purpose of this PR?

Moves the workspace to the current in-tree version of error-stack.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/apps > hash* Affects HASH (a `hash-*` app) area/libs Relates to first-party libraries/crates/packages (area) area/libs > deer Affects the `deer` crate (library) type/eng > backend Owned by the @backend team area/tests New or updated tests area/apps area/apps > hash-graph area/tests > integration New or updated integration tests labels Sep 21, 2024
@indietyp indietyp changed the title Move workspace to v0.6 Move workspace to error-stack v0.6 Sep 21, 2024
@indietyp indietyp force-pushed the bm/error-stack/move-to-v0.6 branch 2 times, most recently from 508b9cb to de5e783 Compare September 21, 2024 03:11
@vilkinsons vilkinsons changed the title Move workspace to error-stack v0.6 H-3342: Move workspace to error-stack v0.6 Sep 21, 2024
@indietyp indietyp force-pushed the bm/error-stack/move-to-v0.6 branch from 10806ec to fcdb39c Compare September 22, 2024 09:30
@indietyp indietyp marked this pull request as ready for review September 22, 2024 09:45
@TimDiekmann TimDiekmann changed the title H-3342: Move workspace to error-stack v0.6 GEN-105, H-3342: Move workspace to error-stack v0.6 Sep 23, 2024
TimDiekmann
TimDiekmann previously approved these changes Sep 23, 2024
Copy link
Member

@TimDiekmann TimDiekmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Base automatically changed from bm/error-stack/experimental-to-unstable to main September 23, 2024 09:04
@TimDiekmann TimDiekmann dismissed their stale review September 23, 2024 09:04

The base branch was changed.

@indietyp indietyp requested a review from a team as a code owner September 23, 2024 09:04
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.72%. Comparing base (1cff852) to head (85f7bc3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5200   +/-   ##
=======================================
  Coverage   19.72%   19.72%           
=======================================
  Files         510      510           
  Lines       17182    17182           
  Branches     2546     2546           
=======================================
  Hits         3390     3390           
  Misses      13780    13780           
  Partials       12       12           
Flag Coverage Δ
apps.hash-ai-worker-ts 1.58% <ø> (ø)
apps.hash-api 1.18% <ø> (ø)
blockprotocol.type-system 55.38% <ø> (ø)
local.hash-backend-utils 9.38% <ø> (ø)
local.hash-isomorphic-utils 1.06% <ø> (ø)
local.hash-subgraph 25.22% <ø> (ø)
rust.deer 5.88% <ø> (ø)
rust.error-stack 72.23% <ø> (ø)
rust.sarif 87.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vilkinsons
vilkinsons previously approved these changes Sep 23, 2024
TimDiekmann
TimDiekmann previously approved these changes Sep 23, 2024
Copy link
Contributor

Benchmark results

@rust/graph-benches – Integrations

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 10 entities $$1.86 \mathrm{ms} \pm 6.03 \mathrm{μs}\left({\color{gray}-0.653 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.02 \mathrm{ms} \pm 6.88 \mathrm{μs}\left({\color{gray}0.598 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.75 \mathrm{ms} \pm 11.1 \mathrm{μs}\left({\color{gray}0.270 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$12.3 \mathrm{ms} \pm 154 \mathrm{μs}\left({\color{gray}-1.404 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.86 \mathrm{ms} \pm 5.26 \mathrm{μs}\left({\color{gray}-1.233 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$2.05 \mathrm{ms} \pm 11.7 \mathrm{μs}\left({\color{gray}-0.184 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$4.00 \mathrm{ms} \pm 16.7 \mathrm{μs}\left({\color{gray}-0.891 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.90 \mathrm{ms} \pm 12.8 \mathrm{μs}\left({\color{gray}1.16 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.05 \mathrm{ms} \pm 21.7 \mathrm{μs}\left({\color{gray}-0.266 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.88 \mathrm{ms} \pm 5.85 \mathrm{μs}\left({\color{gray}-0.256 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$16.7 \mathrm{ms} \pm 213 \mathrm{μs}\left({\color{lightgreen}-14.557 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.9 \mathrm{ms} \pm 154 \mathrm{μs}\left({\color{lightgreen}-29.967 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$15.4 \mathrm{ms} \pm 167 \mathrm{μs}\left({\color{gray}-3.450 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.2 \mathrm{ms} \pm 178 \mathrm{μs}\left({\color{gray}1.44 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$16.2 \mathrm{ms} \pm 163 \mathrm{μs}\left({\color{gray}-0.427 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$15.9 \mathrm{ms} \pm 204 \mathrm{μs}\left({\color{red}5.27 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$16.8 \mathrm{ms} \pm 172 \mathrm{μs}\left({\color{red}6.03 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$15.8 \mathrm{ms} \pm 172 \mathrm{μs}\left({\color{lightgreen}-6.938 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$16.2 \mathrm{ms} \pm 146 \mathrm{μs}\left({\color{gray}-4.014 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$1.41 \mathrm{ms} \pm 3.55 \mathrm{μs}\left({\color{gray}0.171 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 10 entities $$44.9 \mathrm{ms} \pm 2.85 \mathrm{ms}\left({\color{red}42.0 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 50 entities $$268 \mathrm{ms} \pm 1.46 \mathrm{ms}\left({\color{lightgreen}-32.556 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$24.7 \mathrm{ms} \pm 67.2 \mathrm{μs}\left({\color{gray}-1.758 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$72.7 \mathrm{ms} \pm 366 \mathrm{μs}\left({\color{gray}0.283 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$19.8 \mathrm{ms} \pm 76.4 \mathrm{μs}\left({\color{gray}-2.180 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$97.9 \mathrm{ms} \pm 413 \mathrm{μs}\left({\color{gray}-0.112 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$93.7 \mathrm{ms} \pm 519 \mathrm{μs}\left({\color{gray}0.094 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$105 \mathrm{ms} \pm 518 \mathrm{μs}\left({\color{gray}-0.699 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$41.5 \mathrm{ms} \pm 309 \mathrm{μs}\left({\color{gray}0.266 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$79.9 \mathrm{ms} \pm 400 \mathrm{μs}\left({\color{gray}1.41 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$89.4 \mathrm{ms} \pm 821 \mathrm{μs}\left({\color{gray}0.618 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$58.7 \mathrm{ms} \pm 253 \mathrm{μs}\left({\color{gray}0.862 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$53.8 \mathrm{ms} \pm 297 \mathrm{μs}\left({\color{gray}-0.455 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$66.4 \mathrm{ms} \pm 310 \mathrm{μs}\left({\color{gray}-0.677 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$39.0 \mathrm{ms} \pm 353 \mathrm{μs}\left({\color{gray}0.217 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$43.1 \mathrm{ms} \pm 309 \mathrm{μs}\left({\color{gray}-0.179 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$49.8 \mathrm{ms} \pm 290 \mathrm{μs}\left({\color{gray}0.622 \mathrm{\%}}\right) $$ Flame Graph

@indietyp indietyp added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 6df2a34 Sep 23, 2024
158 checks passed
@indietyp indietyp deleted the bm/error-stack/move-to-v0.6 branch September 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-graph area/apps area/deps Relates to third-party dependencies (area) area/libs > deer Affects the `deer` crate (library) area/libs Relates to first-party libraries/crates/packages (area) area/tests > integration New or updated integration tests area/tests New or updated tests type/eng > backend Owned by the @backend team
Development

Successfully merging this pull request may close these issues.

3 participants