Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3777: Replace markdownlint-cli with markdownlint-cli2 #5955

Merged

Conversation

indietyp
Copy link
Member

🌟 What is the purpose of this PR?

markdownlint-cli2 is from the creator of markdownlint itself and runs in parallel, has a lot more options and most importantly does not need the use of a separate markdownlintignore file.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@indietyp indietyp requested a review from CiaranMn December 18, 2024 17:04
@indietyp indietyp self-assigned this Dec 18, 2024
@github-actions github-actions bot added area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area) labels Dec 18, 2024
@indietyp indietyp force-pushed the bm/h-3777-replace-markdownlint-cli-with-markdownlint-cli2 branch from 9e4f56a to 8bd44dd Compare December 18, 2024 17:11
CiaranMn
CiaranMn previously approved these changes Dec 18, 2024
Copy link
Member

@CiaranMn CiaranMn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to lose an ignore file, thank you!

@vilkinsons vilkinsons changed the title H-3777: replace markdownlint-cli with markdownlint-cli2 H-3777: Replace markdownlint-cli with markdownlint-cli2 Dec 18, 2024
@indietyp indietyp added this pull request to the merge queue Dec 18, 2024
Copy link
Contributor

Benchmark results

@rust/hash-graph-benches – Integrations

representative_read_entity

Function Value Mean Flame graphs
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/person/v/1 $$16.8 \mathrm{ms} \pm 224 \mathrm{μs}\left({\color{lightgreen}-29.955 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/building/v/1 $$17.0 \mathrm{ms} \pm 219 \mathrm{μs}\left({\color{gray}-2.616 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/organization/v/1 $$16.6 \mathrm{ms} \pm 187 \mathrm{μs}\left({\color{gray}1.39 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/uk-address/v/1 $$17.3 \mathrm{ms} \pm 235 \mathrm{μs}\left({\color{gray}1.96 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/song/v/1 $$16.3 \mathrm{ms} \pm 195 \mathrm{μs}\left({\color{gray}0.771 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/playlist/v/1 $$15.5 \mathrm{ms} \pm 197 \mathrm{μs}\left({\color{lightgreen}-7.719 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/block/v/1 $$15.9 \mathrm{ms} \pm 210 \mathrm{μs}\left({\color{lightgreen}-8.970 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/page/v/2 $$17.1 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{lightgreen}-28.187 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id entity type ID: https://blockprotocol.org/@alice/types/entity-type/book/v/1 $$16.6 \mathrm{ms} \pm 199 \mathrm{μs}\left({\color{lightgreen}-6.286 \mathrm{\%}}\right) $$ Flame Graph

representative_read_multiple_entities

Function Value Mean Flame graphs
entity_by_property depths: DT=255, PT=255, ET=255, E=255 $$70.1 \mathrm{ms} \pm 474 \mathrm{μs}\left({\color{gray}1.76 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=0 $$41.5 \mathrm{ms} \pm 217 \mathrm{μs}\left({\color{gray}-0.291 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=2, PT=2, ET=2, E=2 $$59.3 \mathrm{ms} \pm 298 \mathrm{μs}\left({\color{gray}0.036 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=0, E=2 $$45.5 \mathrm{ms} \pm 258 \mathrm{μs}\left({\color{gray}0.145 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=0, ET=2, E=2 $$51.2 \mathrm{ms} \pm 265 \mathrm{μs}\left({\color{gray}-1.487 \mathrm{\%}}\right) $$ Flame Graph
entity_by_property depths: DT=0, PT=2, ET=2, E=2 $$55.8 \mathrm{ms} \pm 292 \mathrm{μs}\left({\color{gray}-0.919 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=255, PT=255, ET=255, E=255 $$105 \mathrm{ms} \pm 523 \mathrm{μs}\left({\color{gray}-0.991 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=0 $$41.8 \mathrm{ms} \pm 233 \mathrm{μs}\left({\color{gray}2.13 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=2, PT=2, ET=2, E=2 $$96.1 \mathrm{ms} \pm 382 \mathrm{μs}\left({\color{gray}-1.104 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=0, E=2 $$80.4 \mathrm{ms} \pm 398 \mathrm{μs}\left({\color{gray}0.297 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=0, ET=2, E=2 $$88.2 \mathrm{ms} \pm 583 \mathrm{μs}\left({\color{gray}-0.423 \mathrm{\%}}\right) $$ Flame Graph
link_by_source_by_property depths: DT=0, PT=2, ET=2, E=2 $$92.4 \mathrm{ms} \pm 344 \mathrm{μs}\left({\color{gray}-0.325 \mathrm{\%}}\right) $$ Flame Graph

representative_read_entity_type

Function Value Mean Flame graphs
get_entity_type_by_id Account ID: d4e16033-c281-4cde-aa35-9085bf2e7579 $$2.14 \mathrm{ms} \pm 5.91 \mathrm{μs}\left({\color{gray}0.277 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_one_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$268 \mathrm{ms} \pm 1.07 \mathrm{ms}\left({\color{gray}-3.376 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$27.1 \mathrm{ms} \pm 213 \mathrm{μs}\left({\color{gray}-0.508 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$20.7 \mathrm{ms} \pm 82.7 \mathrm{μs}\left({\color{gray}-2.848 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$57.4 \mathrm{ms} \pm 226 \mathrm{μs}\left({\color{red}7.85 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$178 \mathrm{ms} \pm 833 \mathrm{μs}\left({\color{gray}-1.080 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_linkless

Function Value Mean Flame graphs
entity_by_id 1 entities $$1.94 \mathrm{ms} \pm 8.59 \mathrm{μs}\left({\color{gray}-1.188 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 100 entities $$2.16 \mathrm{ms} \pm 5.82 \mathrm{μs}\left({\color{gray}-1.630 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$1.96 \mathrm{ms} \pm 8.35 \mathrm{μs}\left({\color{gray}-2.229 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1000 entities $$2.92 \mathrm{ms} \pm 12.9 \mathrm{μs}\left({\color{gray}-2.694 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10000 entities $$9.67 \mathrm{ms} \pm 156 \mathrm{μs}\left({\color{gray}2.67 \mathrm{\%}}\right) $$ Flame Graph

scaling_read_entity_complete_zero_depth

Function Value Mean Flame graphs
entity_by_id 50 entities $$4.09 \mathrm{ms} \pm 11.4 \mathrm{μs}\left({\color{gray}0.491 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 5 entities $$1.96 \mathrm{ms} \pm 7.87 \mathrm{μs}\left({\color{gray}-0.323 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 1 entities $$1.96 \mathrm{ms} \pm 16.8 \mathrm{μs}\left({\color{gray}0.212 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 10 entities $$2.14 \mathrm{ms} \pm 8.07 \mathrm{μs}\left({\color{gray}2.23 \mathrm{\%}}\right) $$ Flame Graph
entity_by_id 25 entities $$3.35 \mathrm{ms} \pm 23.5 \mathrm{μs}\left({\color{gray}-0.310 \mathrm{\%}}\right) $$ Flame Graph

Merged via the queue into main with commit 40138b2 Dec 18, 2024
166 checks passed
@indietyp indietyp deleted the bm/h-3777-replace-markdownlint-cli-with-markdownlint-cli2 branch December 18, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps Relates to third-party dependencies (area) area/infra Relates to version control, CI, CD or IaC (area)
Development

Successfully merging this pull request may close these issues.

2 participants