Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3777: Replace markdownlint-cli with markdownlint-cli2 #5955

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@
"/^vite-/",
"/vitest$/",
"/lint-staged/",
"/lockfile-lint/",
"/markdownlint-cli/",
"/markdownlint-cli2/",
"/^prettier/",
"/prettier$/",
"/rimraf/",
Expand Down
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#########################
## Keep in sync with
## - .prettierignore
## - .markdownlintignore
## - .dockerignore
#########################

Expand Down
2 changes: 1 addition & 1 deletion .lefthook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pre-commit:
markdownlint:
tags: frontend style
glob: "*.md"
run: yarn run markdownlint --fix {staged_files} || true
run: yarn run markdownlint-cli2 --fix --no-globs {staged_files} || true
stage_fixed: true
prettier:
tags: frontend style
Expand Down
25 changes: 25 additions & 0 deletions .markdownlint-cli2.jsonc
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"$schema": "https://raw.githubusercontent.com/DavidAnson/markdownlint-cli2/v0.16.0/schema/markdownlint-cli2-config-schema.json",
"config": {
"default": true,
"first-line-heading": false,
"line-length": false,
"list-marker-space": {
"ol_multi": 1,
"ol_single": 1,
"ul_multi": 1,
"ul_single": 1,
},
"no-alt-text": false,
"no-bare-urls": false,
"no-duplicate-heading": { "siblings_only": true },
"no-emphasis-as-heading": false,
"no-inline-html": false,
"no-trailing-punctuation": false,
"ol-prefix": { "style": "one" },
"single-title": false,
},
"gitignore": true,
"globs": ["*.md", "**/*.md"],
"ignores": ["**/LICENSE*.md"],
}
19 changes: 0 additions & 19 deletions .markdownlint.json

This file was deleted.

167 changes: 0 additions & 167 deletions .markdownlintignore

This file was deleted.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,15 @@
"fix:constraints": "yarn constraints --fix",
"fix:eslint": "turbo --continue fix:eslint --",
"fix:taplo": "taplo fmt",
"fix:markdownlint": "markdownlint --dot --fix .",
"fix:markdownlint": "markdownlint-cli2 --fix",
"fix:prettier": "prettier --write --ignore-unknown .",
"fix:yarn-deduplicate": "yarn dedupe --strategy highest",
"lint": "npm-run-all --continue-on-error \"lint:*\"",
"@TODO.2": "Upgrade or remove these blocks and remove the --ignore-package options (also @TODO.1)",
"lint:constraints": "yarn constraints",
"lint:eslint": "turbo --continue lint:eslint --",
"lint:license-in-workspaces": "yarn workspace @local/repo-chores exe scripts/check-license-in-workspaces.ts",
"lint:markdownlint": "markdownlint --dot .",
"lint:markdownlint": "markdownlint-cli2",
"lint:prettier": "prettier --check --ignore-unknown .",
"lint:taplo": "taplo fmt --check",
"lint:tsc": "turbo --continue lint:tsc --",
Expand Down Expand Up @@ -106,7 +106,7 @@
"@taplo/cli": "0.7.0",
"@yarnpkg/types": "^4.0.0",
"lefthook": "1.9.3",
"markdownlint-cli": "0.43.0",
"markdownlint-cli2": "0.16.0",
"npm-run-all2": "7.0.2",
"prettier": "3.4.2",
"prettier-plugin-packagejson": "2.5.6",
Expand Down
Loading
Loading