H-3919: Return error instead of panic in SelectCompiler

apps/hash-graph/src/subcommand/server.rs

@@ -294,7 +294,7 @@ pub async fn server(args: ServerArgs) -> Result<(), Report<GraphError>> {
     let mut zanzibar_client = ZanzibarClient::new(spicedb_client);
     zanzibar_client.seed().await.change_context(GraphError)?;
 
-    let temporal_client_fn = async |host: Option<String>, port: u16| {
+    let temporal_client_fn = |host: Option<String>, port: u16| async move {
         if let Some(host) = host {
             TemporalClientConfig::new(
                 Url::from_str(&format!("{host}:{port}")).change_context(GraphError)?,

libs/@local/graph/api/src/rest/entity.rs

@@ -661,7 +661,7 @@ impl<'q, 's, 'p: 'q> From<GetEntitiesRequest<'q, 's, 'p>> for GetEntitiesParams<
 #[tracing::instrument(
     level = "info",
     skip_all,
-    fields(actor=%actor_id, %request)
+    fields(actor=%actor_id)
 )]
 async fn get_entities<S, A>(
     AuthenticatedUserHeader(actor_id): AuthenticatedUserHeader,

libs/@local/graph/postgres-store/Cargo.toml

@@ -34,6 +34,7 @@ async-scoped   = { workspace = true, features = ["use-tokio"] }
 bytes          = { workspace = true }
 clap           = { workspace = true, optional = true, features = ["derive", "env"] }
 derive-where   = { workspace = true }
+derive_more    = { workspace = true }
 dotenv-flow    = { workspace = true }
 futures        = { workspace = true }
 postgres-types = { workspace = true, features = ["derive", "with-serde_json-1"] }

libs/@local/graph/postgres-store/src/store/postgres/crud.rs

@@ -94,13 +94,15 @@ where
             compiler.set_limit(limit);
         }
 
-        compiler.add_filter(filter);
-
-        let cursor_indices = sorting.compile(
-            &mut compiler,
-            cursor_parameters.as_ref(),
-            temporal_axes.expect("To use a cursor, temporal axes has to be specified"),
-        );
+        compiler.add_filter(filter).change_context(QueryError)?;
+
+        let cursor_indices = sorting
+            .compile(
+                &mut compiler,
+                cursor_parameters.as_ref(),
+                temporal_axes.expect("To use a cursor, temporal axes has to be specified"),
+            )
+            .change_context(QueryError)?;
 
         let record_artifacts = R::parameters();
         let record_indices = R::compile(&mut compiler, &record_artifacts);
@@ -145,7 +147,7 @@ where
         let record_artifacts = R::parameters();
         let record_indices = R::compile(&mut compiler, &record_artifacts);
 
-        compiler.add_filter(filter);
+        compiler.add_filter(filter).change_context(QueryError)?;
         let (statement, parameters) = compiler.compile();
 
         Ok(self
@@ -170,7 +172,7 @@ where
         let record_artifacts = R::parameters();
         let record_indices = R::compile(&mut compiler, &record_artifacts);
 
-        compiler.add_filter(filter);
+        compiler.add_filter(filter).change_context(QueryError)?;
         let (statement, parameters) = compiler.compile();
 
         let rows = self

libs/@local/graph/postgres-store/src/store/postgres/knowledge/entity/mod.rs

@@ -532,7 +532,9 @@ where
                 )
             });
 
-            compiler.add_filter(&params.filter);
+            compiler
+                .add_filter(&params.filter)
+                .change_context(QueryError)?;
 
             let (statement, parameters) = compiler.compile();
 
@@ -620,7 +622,6 @@ where
                 .count();
             let type_ids = type_ids.map(HashMap::from);
 
-            #[expect(clippy::if_then_some_else_none)]
             let type_titles = if params.include_type_titles {
                 let type_uuids = type_ids
                     .as_ref()
@@ -643,7 +644,9 @@ where
                     },
                     ParameterList::EntityTypeIds(&type_uuids),
                 );
-                type_compiler.add_filter(&filter);
+                type_compiler
+                    .add_filter(&filter)
+                    .change_context(QueryError)?;
 
                 let (statement, parameters) = type_compiler.compile();
 

libs/@local/graph/postgres-store/src/store/postgres/ontology/entity_type.rs

@@ -387,7 +387,9 @@ where
                 compiler.add_selection_path(&EntityTypeQueryPath::EditionProvenance(None))
             });
 
-            compiler.add_filter(&params.filter);
+            compiler
+                .add_filter(&params.filter)
+                .change_context(QueryError)?;
 
             let (statement, parameters) = compiler.compile();
 

libs/@local/graph/postgres-store/src/store/postgres/ontology/mod.rs

@@ -35,7 +35,7 @@ use crate::store::{
     postgres::{
         AsClient as _, PostgresStore,
         crud::QueryRecordDecode,
-        query::{Distinctness, PostgresSorting, SelectCompiler},
+        query::{Distinctness, PostgresSorting, SelectCompiler, SelectCompilerError},
     },
 };
 
@@ -153,29 +153,29 @@ macro_rules! impl_ontology_cursor {
                 compiler: &mut SelectCompiler<'p, 'q, $ty>,
                 parameters: Option<&'p Self::CompilationParameters>,
                 _: &QueryTemporalAxes,
-            ) -> Self::Indices {
+            ) -> Result<Self::Indices, Report<SelectCompilerError>> {
                 if let Some(parameters) = parameters {
                     let base_url_expression = compiler.compile_parameter(&parameters.base_url).0;
                     let version_expression = compiler.compile_parameter(&parameters.version).0;
 
-                    VersionedUrlIndices {
+                    Ok(VersionedUrlIndices {
                         base_url: compiler.add_cursor_selection(
                             &<$query_path>::BaseUrl,
                             identity,
                             Some(base_url_expression),
                             Ordering::Ascending,
                             None,
-                        ),
+                        )?,
                         version: compiler.add_cursor_selection(
                             &<$query_path>::Version,
                             identity,
                             Some(version_expression),
                             Ordering::Descending,
                             None,
-                        ),
-                    }
+                        )?,
+                    })
                 } else {
-                    VersionedUrlIndices {
+                    Ok(VersionedUrlIndices {
                         base_url: compiler.add_distinct_selection_with_ordering(
                             &<$query_path>::BaseUrl,
                             Distinctness::Distinct,
@@ -186,7 +186,7 @@ macro_rules! impl_ontology_cursor {
                             Distinctness::Distinct,
                             Some((Ordering::Descending, None)),
                         ),
-                    }
+                    })
                 }
             }
         }

libs/@local/graph/postgres-store/src/store/postgres/ontology/read.rs

@@ -76,7 +76,7 @@ impl<C: AsClient, A: Send + Sync> PostgresStore<C, A> {
         let closed_schema_index =
             compiler.add_selection_path(&EntityTypeQueryPath::ClosedSchema(None));
 
-        compiler.add_filter(filter);
+        compiler.add_filter(filter).change_context(QueryError)?;
         let (statement, parameters) = compiler.compile();
 
         Ok(self