Makefile: github/workflows/frontend: Add i18n-check to CI #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tests so they are not run twice #2125 Running it inside the tests makes the translation files be written when the tests run, causing the tests to run twice. Running it as a pre-commit hook is a bit slow (3.0s), because it looks at all the files that have changed, and then writes all the translation files again. So instead we run it in CI so it catches the issues. Signed-off-by: René Dudfield <renedudfield@microsoft.com>
|
Related to #2140 |
|
If it's too slow as a pre-commit hook then this is a nice alternative. I'll close my PR |
sniok
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests so they are not run twice #2125
Running it inside the tests makes the translation files be written
when the tests run, causing the tests to run twice.
Running it as a pre-commit hook is a bit slow (3.0s), because
it looks at all the files that have changed, and then writes all
the translation files again.
So instead we run it in CI so it catches the issues.