Feature/capture magewell #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta for the MOV container. Vidoe doesn't get saved properly but this is the correct pipeline.
… mp4. Runs for 10 seconds with no frame capture.
…orrectly for real on security camera
… feature/capture-video-demo
… feature/capture-video-demo
…era class? Need to see if we need that comment
…ted out a MagewellMuxer and MagewellDemuxer to enable cropping logs corrrectly
ds58
requested changes
Aug 5, 2024
src/test/java/us/ihmc/robotDataLogger/captureVideo/ExampleBytedecoWindowsScreenRecord.java
Show resolved
Hide resolved
|
Can you add me back as a review when it's ready? |
rjgriffin42
reviewed
Aug 8, 2024
| recorder.setVideoOption("tune", "zerolatency"); | ||
| recorder.setVideoCodec(avcodec.AV_CODEC_ID_MPEG4); | ||
| recorder.setFormat("mov"); | ||
| recorder.setFrameRate(60); |
There was a problem hiding this comment.
is it important that the grabber and recorder use the same frame rate? If it is, should you make a variable called framerate and pass that in, to future proof against some dummy trying to change the rate?
rjgriffin42
reviewed
Aug 8, 2024
src/main/java/us/ihmc/robotDataLogger/logger/MagewellVideoDataLogger.java
Outdated
Show resolved
Hide resolved
rjgriffin42
reviewed
Aug 8, 2024
src/main/java/us/ihmc/robotDataLogger/logger/MagewellVideoDataLogger.java
Outdated
Show resolved
Hide resolved
rjgriffin42
reviewed
Aug 8, 2024
src/main/java/us/ihmc/robotDataLogger/logger/MagewellVideoDataLogger.java
Show resolved
Hide resolved
rjgriffin42
reviewed
Aug 8, 2024
src/test/java/us/ihmc/robotDataLogger/captureVideo/ExampleBytedecoWindowsScreenRecord.java
Outdated
Show resolved
Hide resolved
ds58
reviewed
Aug 8, 2024
src/main/java/us/ihmc/robotDataLogger/logger/MagewellVideoDataLogger.java
Show resolved
Hide resolved
PotatoPeeler3000
added a commit
to ihmcrobotics/simulation-construction-set-2
that referenced
this pull request
Aug 21, 2024
This PR allows for viewing videos and logs recorded with a Magewell capture device. Unfortunately videos recorded with Magewell can't be played back with the previous implementation so a specific magewell one had to be made resulting in the following interface `VideoDataPlayer` which has specific implementations for Magewell and Blackmagic. This follows the logger PR to enable logging with ihmcrobotics/ihmc-robot-data-logger#8 --------- Co-authored-by: nkitchel <nkitchel@ihmc.us> Co-authored-by: ds58 <30220598+ds58@users.noreply.github.com>
# Conflicts: # src/test/java/us/ihmc/robotDataLogger/captureVideo/ExampleGStreamerUbuntuCapture.java # src/test/java/us/ihmc/robotDataLogger/captureVideo/ExampleMagewellVideoDataPlayer.java # src/test/java/us/ihmc/robotDataLogger/captureVideo/MagewellDemuxerFrameExistsTest.java
…ne place, added helpful comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to capture videos and log them properly with a different capture device. The specific implementation is called Magewell. ExampleMagewellCapture and ExampleMagewellVideoDataPlayer provide a simple implmentation of how to record and view a video.
To keep things clear the previous implementation is now all labeled as Blackmagic, and there is a GStreamer logger added as well which doesn't yet work but is there for future development
Most of the other changes was updating print statments and passing the new camera option through all the classes.
The accompanying PR for SCS2 is here: ihmcrobotics/simulation-construction-set-2#183 and explains how logs get viewed with the new magewell capture, cropping works as well.