Fixed issue #53, solves login button's contrast ratio at admin login

[ahamed]

Pull Request for Issue #53.

Summary of Changes

Added gradient button instead of the flat primary button which resolves the contrast ratio problem.

[brianteeman]

the changes here break the usage of the atum template. This template is supposed to be an alternative template and not a replacement template. Everytime you do something to break atum you create more work later on.

[kawshar]

The newly designed interface can not keep everything from Atum. We were asked to keep the backward compatibility. We are not breaking the core. If we keep everything from Atum, we will not be able to innovate.

[brianteeman]

The newly designed interface can not keep everything from Atum.

Agreed

We are not breaking the core.

If a change made in this repo breaks the atum template then you are.

[kawshar]

Btw, the changes here made are realistic. I think Atum needs a change here. .btn-solid-primary is kinda confusing.

[kawshar]

Instead .btn-primary is practical.

[brianteeman]

Then the change needs to be made in the main repo and not here

[kawshar]

Then someone needs to do that. We can not focus on to many things. It's beyond our scope. What we can do, we can add an extra class by keeping the old solid class.

[brianteeman]

Then you can never satisfy the requirements for this template to be accepted as an alternative to atum

[kawshar]

Why don't you ask the users which one they want? If Atum gets major votes then we will get out of it and will start contributing to the Atum.

Just share this comparison and see users reactions https://github.com/joomla-projects/j4adminui/wiki/How-we-introduced-design-thinking-in-Joomla-4-Admin-Template

[brianteeman]

That's not for me to decide and is not what the production department asked for (from what I can tell in the readme)

[brianteeman]

and that document is a joke as it is not what you have delivered - would be great if it had been - just check the accessibility section of that document and compare it to the list of breaking accessibility issues I found in just one hour and the response from your developer that accessibility is not important and we should not be designing for the minority of people.

I will repeat what I have said before - there are some really good ideas and concepts in this template and those ideas and concepts could and should be the default - but as it is right now this is not an alternative template and it doesnt meet the requirements

[kawshar]

Can you please tell us what ideas you liked from our concept? I would like to know.

Thanks

[marcodings]

An alternate template would mean that they can coexist. If changes introduced by Khonsu break Autum that is not ok. The will ultimately come to light when/if we merge (as we postponend that by using a seperate repo.
However if problems are apperent at this stage we should fix them now, in khonsu or in the commen code base if the observed problem has its root cause outside of khonsu

[brianteeman]

They are massively obvious now on every single page

[brianteeman]

@marcodings its super easy to see why and where this template breaks atum.

Option 1. Install this repo and then change the template to atum and observe how everything on every page is broken

Option 2. Check the changed files. Anything that is not in the templates/khonso folder should not have been changed. A few of those changes can be moved into the template as overrides but as far as I am aware xml files and view.html.php files can not be overridden.

[thaoredweb]

What should we can check here? The contrast radio of button or user name field

[C-Lodder]

@kawshar @marcodings
I'm not sure if this will be merged into core as an alternative template or whether it will be completely standalone installable. Either way, you have made changes to core view files. Atum will be the default J4 template (unless they want to postpone Joomla for another 2-3 years), so the minute you make core view changes, it will affect Atum. If you need to make any changes to view, they either need to be implemented in core repo, or you'll need to create an override.

As it stands now, you have to install two completely separate instances of Joomla from two different repos to be able to use the two templates, whereas you should be able to easily switch between the two templates in the Admin panel.

This is the point @brianteeman was trying to make.

This is not a template, but instead a fork of Joomla. Unless you somehow persuade production to replace Atum with this or revert core changes, you're pretty much f***ed.

[brianteeman]

@C-Lodder Dont waste your breath.