Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest jackson 2.18.0 #167

Closed
wants to merge 1 commit into from
Closed

Conversation

vzorge
Copy link

@vzorge vzorge commented Oct 15, 2024

No description provided.

@vzorge vzorge mentioned this pull request Oct 15, 2024
@joschi
Copy link
Owner

joschi commented Oct 15, 2024

@vzorge Thanks for your contribution!

This is essentially the same PR as #165 right now.

Please also sync the actual Java code with com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.0.

@vzorge
Copy link
Author

vzorge commented Oct 15, 2024

The problem with #165 is that the build fails because the junit dependency update is not there.

@joschi What do you mean with syncing the Java code?

@joschi
Copy link
Owner

joschi commented Oct 15, 2024

What do you mean with syncing the Java code?

This project is mirroring the code of com.fasterxml.jackson.datatype:jackson-datatype-jsr310 and replaces any use of java.time.* with org.threeten.bp.* to get a high degree of compatibility with the actual Jackson module plus making it compatible with older Java versions.

If you look at the changes of the upstream module at FasterXML/jackson-modules-java8@jackson-modules-java8-2.15.2...jackson-modules-java8-2.18.0, you can see that there were some changes since version 2.15.2 was released.

These changes have to be ported into this project.

@joschi
Copy link
Owner

joschi commented Oct 29, 2024

@vzorge Any news? Do you have time to port the code changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants