-
Notifications
You must be signed in to change notification settings - Fork 2
add toolchain build/push and install scripts #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a bunch of suggestions from running shellcheck
locally, not sure why CI didn't pick up on them. Let me look into it.
On my local, shellcheck v0.9.0 is not providing any suggestion. Which version of shellcheck are you using? EDIT: I can see the |
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Signed-off-by: Francesco Ilario <filario@redhat.com>
Yes, I've largely been running it locally with the |
I think those extra checks are good to have. As #66 is merged, we'll have them by default without needing the |
I'll go take out |
Filed #67. |
Signed-off-by: Francesco Ilario filario@redhat.com