Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Using the correct port #195

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

GiuseppeMonetti95
Copy link
Contributor

With this PR, a solution for the issue #194 is proposed.

It happens because in the Sunrise Java application, the remote port is set at this line and, by default, also the port on Controller side is set to the same value (see the screenshot of the official FRI documentation below).

image

The issue could be fixed in two possible ways:

  1. The client_port parameter can be used for establishing the FRI communication, instead of the standard port 30200.
  2. Setting the port on controller side to 30200 using setPortOnController() function and using two different port for the UDP connection on client side.

The documentation states:

Note: Only change the port number on the robot controller if the application requires different port numbers on both sides of the FRI channel.

In my interpretation, the port on the controller side should be different from the one on client side only if the application requires explicitly two different ports on the two sides.
Given that this one is not the case, and that the fix is extremely easy when we set the client_port on both sides, I implemented the first fix.

Copy link

@Svastits Svastits merged commit 08ccda7 into kroshu:master Oct 18, 2024
3 checks passed
Svastits pushed a commit that referenced this pull request Oct 24, 2024
Co-authored-by: Giuseppe Monetti <giuseppe.monetti@kuka.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants