Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, a solution for the issue #194 is proposed.
It happens because in the Sunrise Java application, the remote port is set at this line and, by default, also the port on Controller side is set to the same value (see the screenshot of the official FRI documentation below).
The issue could be fixed in two possible ways:
The documentation states:
In my interpretation, the port on the controller side should be different from the one on client side only if the application requires explicitly two different ports on the two sides.
Given that this one is not the case, and that the fix is extremely easy when we set the client_port on both sides, I implemented the first fix.