Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mutationの選択オプションを追加 #813

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Conversation

tt-kuma
Copy link
Contributor

@tt-kuma tt-kuma commented Dec 7, 2020

resolve #643

--mutation-typeオプションを追加して,実行時にMutationの種類を選択できるようにした.
現状,#806 によりHeuristicを使おうとするとkgpが落ちるためデフォルトはSimpleに設定.

Comment on lines +1003 to +1008
public Mutation.Type convertToField(final String value) {
if (value == null) {
return null;
}
return Mutation.Type.valueOf(value);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this Pull Request, this code fragment in In this Pull Request, above code fragment is added to below clone set,

public SecondVariantSelectionStrategy.Strategy convertToField(final String value) {
if (value == null) {
return null;
}
return SecondVariantSelectionStrategy.Strategy.valueOf(value);
}

public Crossover.Type convertToField(final String value) {
if (value == null) {
return null;
}
return Crossover.Type.valueOf(value);
}

public FirstVariantSelectionStrategy.Strategy convertToField(final String value) {
if (value == null) {
return null;
}
return FirstVariantSelectionStrategy.Strategy.valueOf(value);
}

public Scope.Type convertToField(final String value) {
if (value == null) {
return null;
}
return Scope.Type.valueOf(value);
}

Why don't you merge it?

Comment on lines +1011 to +1016
public String convertFromField(final Mutation.Type value) {
if (value == null) {
return null;
}
return value.toString();
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this Pull Request, this code fragment in In this Pull Request, above code fragment is added to below clone set,

public String convertFromField(final SecondVariantSelectionStrategy.Strategy value) {
if (value == null) {
return null;
}
return value.toString();
}

public String convertFromField(final Technique value) {
if (value == null) {
return null;
}
return value.toString();
}

public String convertFromField(final Crossover.Type value) {
if (value == null) {
return null;
}
return value.toString();
}

public String convertFromField(final FirstVariantSelectionStrategy.Strategy value) {
if (value == null) {
return null;
}
return value.toString();
}

public String convertFromField(final Scope.Type value) {
if (value == null) {
return null;
}
return value.toString();
}

public String convertFromField(final Path value) {
if (value == null) {
return null;
}
return value.toString();
}

Why don't you merge it?

@tt-kuma tt-kuma requested a review from YoshikiHigo December 7, 2020 05:40
Copy link
Member

@YoshikiHigo YoshikiHigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認しました,良さそうなのでマージします.
お疲れさんでした!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HeuristicMutation を簡単に利用できない
2 participants