Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli highlighting fix #4773

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Cli highlighting fix #4773

merged 2 commits into from
Jan 23, 2025

Conversation

MSebanc
Copy link
Collaborator

@MSebanc MSebanc commented Jan 22, 2025

Description

CLI error highlighting was improperly looking for escaped quotes. Fixed to look for \' and \".

Fixes #4758

Contributor agreement

@MSebanc MSebanc requested a review from andyfengHKU January 22, 2025 22:26
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.31%. Comparing base (99dd5dc) to head (15cc629).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4773   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files        1397     1397           
  Lines       59935    59935           
  Branches     7384     7384           
=======================================
  Hits        51734    51734           
  Misses       8034     8034           
  Partials      167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark Result

Master commit hash: 99dd5dca0fa03b0ca9af007f794b2e85c497c9a5
Branch commit hash: babf81bf5f159e42aca6f50fe085ae1c3e7b80e9

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 639.08 639.72 -0.64 (-0.10%)
aggregation q28 11581.16 11523.78 57.38 (0.50%)
filter q14 127.40 129.41 -2.02 (-1.56%)
filter q15 128.02 127.07 0.96 (0.75%)
filter q16 304.21 305.87 -1.66 (-0.54%)
filter q17 448.23 446.23 2.00 (0.45%)
filter q18 1932.21 1926.06 6.15 (0.32%)
filter zonemap-node 89.96 88.56 1.40 (1.58%)
filter zonemap-node-lhs-cast 88.71 89.70 -0.99 (-1.11%)
filter zonemap-node-null 84.67 85.53 -0.85 (-1.00%)
filter zonemap-rel 5787.48 5818.59 -31.11 (-0.53%)
fixed_size_expr_evaluator q07 589.25 583.91 5.35 (0.92%)
fixed_size_expr_evaluator q08 811.84 808.83 3.01 (0.37%)
fixed_size_expr_evaluator q09 813.52 810.24 3.28 (0.40%)
fixed_size_expr_evaluator q10 247.10 248.17 -1.06 (-0.43%)
fixed_size_expr_evaluator q11 240.11 240.45 -0.33 (-0.14%)
fixed_size_expr_evaluator q12 234.84 236.17 -1.33 (-0.56%)
fixed_size_expr_evaluator q13 1615.37 1458.38 157.00 (10.77%)
fixed_size_seq_scan q23 116.34 122.21 -5.87 (-4.80%)
join q29 571.54 613.07 -41.54 (-6.77%)
join q30 10492.92 10249.64 243.28 (2.37%)
join q31 6.30 4.49 1.81 (40.38%)
join SelectiveTwoHopJoin 52.41 53.25 -0.84 (-1.57%)
ldbc_snb_ic q35 2563.40 2620.03 -56.64 (-2.16%)
ldbc_snb_ic q36 475.79 451.14 24.65 (5.46%)
ldbc_snb_is q32 4.49 6.09 -1.60 (-26.31%)
ldbc_snb_is q33 16.10 14.13 1.97 (13.94%)
ldbc_snb_is q34 1.42 1.37 0.06 (4.05%)
multi-rel multi-rel-large-scan 1592.64 1410.09 182.54 (12.95%)
multi-rel multi-rel-lookup 11.17 33.52 -22.35 (-66.68%)
multi-rel multi-rel-small-scan 87.03 91.85 -4.82 (-5.25%)
order_by q25 131.80 134.38 -2.58 (-1.92%)
order_by q26 469.43 471.36 -1.93 (-0.41%)
order_by q27 1467.06 1470.36 -3.30 (-0.22%)
recursive_join recursive-join-bidirection 295.13 276.38 18.75 (6.78%)
recursive_join recursive-join-dense 7431.48 7357.94 73.54 (1.00%)
recursive_join recursive-join-path 23744.83 23584.85 159.98 (0.68%)
recursive_join recursive-join-sparse 1056.57 1065.69 -9.12 (-0.86%)
recursive_join recursive-join-trail 7378.71 7328.53 50.18 (0.68%)
scan_after_filter q01 172.86 170.29 2.58 (1.51%)
scan_after_filter q02 159.86 156.97 2.89 (1.84%)
shortest_path_ldbc100 q37 82.56 89.83 -7.27 (-8.10%)
shortest_path_ldbc100 q38 376.04 372.42 3.62 (0.97%)
shortest_path_ldbc100 q39 61.36 63.85 -2.49 (-3.90%)
shortest_path_ldbc100 q40 442.20 474.96 -32.75 (-6.90%)
var_size_expr_evaluator q03 2078.32 2087.52 -9.20 (-0.44%)
var_size_expr_evaluator q04 2231.83 2233.12 -1.29 (-0.06%)
var_size_expr_evaluator q05 2677.79 2644.47 33.32 (1.26%)
var_size_expr_evaluator q06 1668.20 1326.85 341.35 (25.73%)
var_size_seq_scan q19 1448.45 1451.82 -3.37 (-0.23%)
var_size_seq_scan q20 2730.77 2717.07 13.70 (0.50%)
var_size_seq_scan q21 2287.88 2299.77 -11.89 (-0.52%)
var_size_seq_scan q22 127.36 126.94 0.42 (0.33%)

@andyfengHKU andyfengHKU merged commit bdb428b into master Jan 23, 2025
25 checks passed
@andyfengHKU andyfengHKU deleted the cli-highlighting-fix branch January 23, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect highlighting error in CLI
2 participants