Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli highlighting fix #4773

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Cli highlighting fix #4773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5277bae
Fixed cli highlighting error
MSebanc Jan 22, 2025
15cc629
updated comment
MSebanc Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions tools/shell/linenoise.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1760,8 +1760,7 @@ void addErrorHighlighting(uint64_t render_start, uint64_t render_end,
case ScanState::IN_SINGLE_QUOTE:
// single quote - all that will get us out is an unescaped single-quote
if (c == '\'') {
if (i + 1 < l->len && l->buf[i + 1] == '\'') {
// double single-quote means the quote is escaped - continue
if (i > 0 && l->buf[i - 1] == '\\') { // escaped quote
i++;
break;
} else {
Expand All @@ -1774,8 +1773,7 @@ void addErrorHighlighting(uint64_t render_start, uint64_t render_end,
case ScanState::IN_DOUBLE_QUOTE:
// double quote - all that will get us out is an unescaped quote
if (c == '"') {
if (i + 1 < l->len && l->buf[i + 1] == '"') {
// double quote means the quote is escaped - continue
if (i > 0 && l->buf[i - 1] == '\\') { // escaped quote
i++;
break;
} else {
Expand Down
Loading