Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add Cilium BGP LB e2e test #290

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[test] Add Cilium BGP LB e2e test #290

wants to merge 15 commits into from

Conversation

komer3
Copy link
Contributor

@komer3 komer3 commented Jan 9, 2025

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions bot added the testing for updates to the testing suite in the changelog. label Jan 9, 2025
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated
Comment on lines 200 to 227
KUBECONFIG=$(KUBECONFIG_PATH) kubectl -n kube-system patch daemonset ccm-linode --patch '\
spec:\
template:\
spec:\
containers:\
- name: ccm-linode\
args:\
- --leader-elect-resource-lock=leases\
- --v=3\
- --secure-port=10253\
- --webhook-secure-port=0\
- --enable-route-controller=true\
- --vpc-name=capl-cluster\
- --configure-cloud-routes=true\
- --cluster-cidr=10.0.0.0/8\
- --load-balancer-type=cilium-bgp\
- --bgp-node-selector=cilium-bgp-peering=true\
- --ip-holder-suffix=e2e-test
KUBECONFIG=$(KUBECONFIG_PATH) kubectl patch clusterrole ccm-linode-clusterrole --type='json' \
-p='[{\
"op": "add",\
"path": "/rules/-",\
"value": {\
"apiGroups": ["cilium.io"],\
"resources": ["ciliumloadbalancerippools", "ciliumbgppeeringpolicies"],\
"verbs": ["get", "list", "watch", "create", "update", "patch", "delete"]\
}\
}]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we make the bgp stuff configurable in https://github.com/linode/linode-cloud-controller-manager/blob/main/deploy/generate-manifest.sh then we don't have to do this patching. That's probably worth adding since right now the raw manifest needs to be manually edited versus setting the options in the helm chart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm so we would regen the manifest with bgp enabled and apply the patches?

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.62%. Comparing base (1b2351c) to head (738fb4b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #290   +/-   ##
=======================================
  Coverage   70.62%   70.62%           
=======================================
  Files          11       11           
  Lines        2172     2172           
=======================================
  Hits         1534     1534           
  Misses        488      488           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants