-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add Cilium BGP LB e2e test #290
base: main
Are you sure you want to change the base?
Conversation
Makefile
Outdated
KUBECONFIG=$(KUBECONFIG_PATH) kubectl -n kube-system patch daemonset ccm-linode --patch '\ | ||
spec:\ | ||
template:\ | ||
spec:\ | ||
containers:\ | ||
- name: ccm-linode\ | ||
args:\ | ||
- --leader-elect-resource-lock=leases\ | ||
- --v=3\ | ||
- --secure-port=10253\ | ||
- --webhook-secure-port=0\ | ||
- --enable-route-controller=true\ | ||
- --vpc-name=capl-cluster\ | ||
- --configure-cloud-routes=true\ | ||
- --cluster-cidr=10.0.0.0/8\ | ||
- --load-balancer-type=cilium-bgp\ | ||
- --bgp-node-selector=cilium-bgp-peering=true\ | ||
- --ip-holder-suffix=e2e-test | ||
KUBECONFIG=$(KUBECONFIG_PATH) kubectl patch clusterrole ccm-linode-clusterrole --type='json' \ | ||
-p='[{\ | ||
"op": "add",\ | ||
"path": "/rules/-",\ | ||
"value": {\ | ||
"apiGroups": ["cilium.io"],\ | ||
"resources": ["ciliumloadbalancerippools", "ciliumbgppeeringpolicies"],\ | ||
"verbs": ["get", "list", "watch", "create", "update", "patch", "delete"]\ | ||
}\ | ||
}]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we make the bgp stuff configurable in https://github.com/linode/linode-cloud-controller-manager/blob/main/deploy/generate-manifest.sh then we don't have to do this patching. That's probably worth adding since right now the raw manifest needs to be manually edited versus setting the options in the helm chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm so we would regen the manifest with bgp enabled and apply the patches?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
=======================================
Coverage 70.62% 70.62%
=======================================
Files 11 11
Lines 2172 2172
=======================================
Hits 1534 1534
Misses 488 488
Partials 150 150 ☔ View full report in Codecov by Sentry. |
… with makefile patches
General:
Pull Request Guidelines: