Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add Cilium BGP LB e2e test #290
base: main
Are you sure you want to change the base?
[test] Add Cilium BGP LB e2e test #290
Changes from 5 commits
b6af5a7
bd9cb3f
104f1a5
275cfc0
bf4ed94
4efe366
0359ebd
fce1d2a
827b153
b1ad112
422b7ca
fa28e56
6190572
4c3ef44
738fb4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we make the bgp stuff configurable in https://github.com/linode/linode-cloud-controller-manager/blob/main/deploy/generate-manifest.sh then we don't have to do this patching. That's probably worth adding since right now the raw manifest needs to be manually edited versus setting the options in the helm chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm so we would regen the manifest with bgp enabled and apply the patches?