change: [M3-8343] - Change VPC expanded header background color #11366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-akamai
reviewed
Dec 5, 2024
Co-authored-by: Harsh Shankar Rao <hrao@akamai.com>
Cloud Manager UI test results🔺 1 failing test on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/objectStorage/access-key.e2e.spec.ts" |
|||||||||||||||||
hasyed-akamai
added
React Query
hasyed-akamai
requested review from
hana-akamai and
hkhalil-akamai
and removed request for
a team
hana-akamai
reviewed
Dec 10, 2024
| sx={(theme) => ({ | ||
| '& .MuiTableCell-root': { | ||
| backgroundColor: | ||
| theme.name == 'light' ? theme.color.black : undefined, |
There was a problem hiding this comment.
Per the Figma mockup, the black should be #343438 instead of #232326
I also added a comment to the ticket to get some clarification on the focus and hover filterable table head colors since that was not mocked in the Figma
| Figma | This branch |
|---|---|
 |
 |
|
Closing - Let's move these changes over to our feature branch as discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This pull request updates the background color of the VPC expanded header for improved visual clarity and design consistency. The new color provides better contrast, ensuring the header is more distinguishable from surrounding elements.
Changes 🔄
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
As an Author I have considered 🤔
Check all that apply