Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [M3-8343] - Change VPC expanded header background color #11366

Closed
wants to merge 3 commits into from
Closed

change: [M3-8343] - Change VPC expanded header background color #11366

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f06ce4
change: [M3-8343] - Change VPC expanded header background color
hasyed-akamai Dec 4, 2024
83ff82a
Added changeset: Change VPC expanded header background color
hasyed-akamai Dec 4, 2024
00d581e
Update changeset description
hasyed-akamai Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11366-changed-1733315498672.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Changed
---

Change VPC expanded header background color ([#11366](https://github.com/linode/manager/pull/11366))
hasyed-akamai marked this conversation as resolved.
Show resolved Hide resolved
9 changes: 8 additions & 1 deletion packages/manager/src/features/VPCs/VPCDetail/SubnetLinodeRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,14 @@ const getFirewallLinks = (data: Firewall[]): JSX.Element => {
};

export const SubnetLinodeTableRowHead = (
<TableRow>
<TableRow
sx={(theme) => ({
'& .MuiTableCell-root': {
backgroundColor:
theme.name == 'dark' ? theme.tokens.color.Neutrals[80] : undefined,
},
})}
>
<StyledTableHeadCell>Linode Label</StyledTableHeadCell>
<StyledTableHeadCell sx={{ width: '14%' }}>Status</StyledTableHeadCell>
<Hidden smDown>
Expand Down
16 changes: 14 additions & 2 deletions packages/manager/src/features/VPCs/VPCDetail/VPCSubnetsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,15 @@ export const VPCSubnetsTable = (props: Props) => {
}

const SubnetTableRowHead = (
<TableRow>
<TableRow
sx={(theme) => ({
'& .MuiTableCell-root': {
backgroundColor:
theme.name == 'light' ? theme.color.black : undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the Figma mockup, the black should be #343438 instead of #232326

I also added a comment to the ticket to get some clarification on the focus and hover filterable table head colors since that was not mocked in the Figma

Figma This branch
image image

color: theme.name == 'light' ? `${theme.color.white}` : undefined,
},
})}
>
<StyledTableSortCell
sx={(theme) => ({
[theme.breakpoints.down('sm')]: {
Expand Down Expand Up @@ -204,7 +212,7 @@ export const VPCSubnetsTable = (props: Props) => {
<Hidden smDown>
<StyledTableCell sx={{ width: '10%' }}>Linodes</StyledTableCell>
</Hidden>
<StyledTableCell></StyledTableCell>
<StyledTableCell />
</TableRow>
);

Expand Down Expand Up @@ -364,6 +372,10 @@ const StyledTableCell = styled(TableCell, {
const StyledTableSortCell = styled(TableSortCell, {
label: 'StyledTableSortCell',
})(({ theme }) => ({
'& .Mui-active': {
color: theme.name == 'light' ? `${theme.color.white}` : undefined,
},
borderBottom: `1px solid ${theme.borderColors.borderTable} !important`,
color: theme.name == 'light' ? `${theme.color.white}` : undefined,
whiteSpace: 'nowrap',
}));
Loading