upcoming: [DI-22558] - Added Trigger condition and Dimension Filter components #11445

santoshp210-akamai · 2024-12-19T20:04:33Z

Description 📝

Added Dimension Filters feature to the Metric Criteria component
Added Trigger condition component to the Create Alert Form under Criteria section

Changes 🔄

Added DimensionFilter component which has a FieldArray to add the DimensionFilterField components dynamically
Added the Autocomplete components for Data Field, Operator and Value in DimensionFilterField
Added the Autocomplete and TextField components for Evaluation Period, Polling Interval and Trigger Occurrences in DimensionFilterField
Added and changed some types of CreateAlertDefinitionPayload, Alert interfaces
Changed some types for MetricCriteriaForm,CreateAlertPayloadForm and added DimensionFiltersForm, TriggerConditionForm
Changed the filterFormValues utility methods for MetricCriteriaForm interfaces and added DimensionFilterForm and TriggerConditionForm interfaces

Target release date 🗓️

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)

The tabs are controlled by a featureFlag called aclpAlerting, the flag has been currently disabled. For testing enable the definitions part of the aclpAlerting flag to be true.
The API endpoints are not live yet, so use Legacy MSW Handlers for the mock responses
In Monitor (once the prerequisites are followed) , Alerts tab should be visible next to Dashboards.
Under that, Definition tab and a Create button should be visible.
On clicking Create, the Form Page should be visible
To choose from the Data Field drop down, selecting a Service is required

Verification steps

(How to verify changes)

The DimensionFilters component should be visible when clicked on the AddDimensionFilter Button
Once a Metric Data Field is selected, Dimension Filter Data Field can be selected
For the Value field in DimensionFilter component, Dimension Filter Data Field is required
For Trigger Conditions the Polling Interval and Evaluation Period components the options are dependent on the Service selected. Should be able to select and choose a value
The displayed options in Polling Interval and Evaluation Period components must be greater than or equal to the scrape interval of the selected Metric Data Field

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…hanges

…n for error validation and minor changes

…es in validation schema

jaalah-akamai

Overall works and looks good - just some UX issues and perf questions I have:

UX Issues

Validation Error Never Resolves	Re-renderings for Data Field - other fields good
	re-renders.mov

packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilter.tsx

packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterField.tsx

packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/TriggerConditions.tsx

santoshp210-akamai · 2024-12-24T05:23:58Z

#11445 (review), @jaalah-akamai , from what I remember for the Metric discussions, I had informed about these issues for the screens like Ipad or tablet like screens when they are in potrait mode. I will see to the UX changes.

santoshp210-akamai · 2024-12-24T14:11:04Z

@jaalah-akamai , For the re-renderings issue we also not sure what's causing this behaviour. From our observations it is re-rendering entire page when we clear an option or we choose CPU utilization. Not sure what's causing this behavior

bnussman-akamai · 2024-12-24T18:10:52Z

I believe that re-render is happening because of the maxScrapeInterval state. When a "Data Field" is selected, it causes maxScrapeInterval to be set, which will re-render the entire form because the maxScrapeInterval state is at the top-level component of the form.

santoshp210-akamai · 2024-12-24T18:20:28Z

@bnussman-akamai, #11445 (comment) as per this, in this particular situation is it okay for the form to re-render just for that one field ? As we do want to pass it through the top-level component.
cc: @jaalah-akamai

… to the component

jaalah-akamai · 2024-12-26T13:48:52Z

@bnussman-akamai, #11445 (comment) as per this, in this particular situation is it okay for the form to re-render just for that one field ? As we do want to pass it through the top-level component. cc: @jaalah-akamai

FormContext may be an option here and we could just remove that field from the payload, but this can be an optimization we make maybe with your UX changes.

Updated stylings

santoshp210-akamai · 2024-12-27T14:33:48Z

@jaalah-akamai , The UX changes have been pushed. The units are still overloading in some situations, but there is plan to use them as adornments with using a shortened form for the units. That will be pursued as an enhancement once all the features are done. Regarding the error validation resolution, I'm not able to pinpoint why the issue is happening and requesting if there was a similar behaviour before with setValue usage in the code. Any reasoning or documentation for this specific behaviour would be helpful. Thank you

…ic Data Field and Dimension Filter Data Field

…d of exporting to fix the failing tests

github-actions · 2024-12-30T19:23:40Z

Coverage Report: ❌
Base Coverage: 86.97%
Current Coverage: 86.94%

…osh_type_fixes

Merge latest linode develop and type changes

…rs-and-trigger-conditions

linode-gh-bot · 2025-01-06T11:04:41Z

Cloud Manager UI test results

🎉 471 passing tests on test run #18 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`0 Failing`	`471 Passing`	`2 Skipped`	`91m 6s`

cypress · 2025-01-07T23:09:00Z

Cloud Manager E2E Run #7052

Run Properties: Failed #7052 • b47661f73b: upcoming: [DI-22558] - Added Trigger condition and Dimension Filter components (...

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Failed #7052`
Run duration	`23m 32s`
Commit	`b47661f73b: upcoming: [DI-22558] - Added Trigger condition and Dimension Filter components (...`
Committer	`santoshp210-akamai`
View all properties for this run ↗︎

Test results
Failures	`23`
Flaky	`1`
Pending	`2`
Skipped	`0`
Passing	`455`
View all changes introduced in this branch ↗︎

Tests for review

linodes/clone-linode.spec.ts • 1 failed test

View Output Video

Test		Artifacts
clone linode > can clone a Linode from Linode details page		`Screenshots` `Video`

stackscripts/create-stackscripts.spec.ts • 1 failed test

View Output Video

Test		Artifacts
Create stackscripts > creates a StackScript with Any/All target image		`Screenshots` `Video`

linodes/rebuild-linode.spec.ts • 2 failed tests

View Output Video

Test		Artifacts
rebuild linode > rebuilds a linode from Image		`Screenshots` `Video`
rebuild linode > rebuilds a linode from Community StackScript		`Screenshots` `Video`

firewalls/update-firewall.spec.ts • 3 failed tests

View Output Video

Test		Artifacts
update firewall > updates a firewall's linodes and rules		`Screenshots` `Video`
update firewall > updates a firewall's status		`Screenshots` `Video`
update firewall > updates a firewall's label		`Screenshots` `Video`

firewalls/create-firewall.spec.ts • 1 failed test

View Output Video

Test		Artifacts
create firewall > creates a firewall assigned to a linode		`Screenshots` `Video`

The first 5 failed specs are shown, see all 13 specs in Cypress Cloud.

cypress/e2e/core/linodes/linode-config.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
Linode Config management > End-to-End > Clones a config		`Screenshots` `Video`

…omponents (linode#11445) * upcoming: [DI-22558] - Added Trigger condition and Dimension Filter changes * removed unnecessary console log statement * upcoming: [DI-22558] - Importing right interface for Trigger condition for error validation and minor changes * upcoming: [DI-22588] - Added the Unit Tests for the components * upcoming: [DI-22588] - Added changesets and few changes to the messages in validation schema * upcoming: [DI-22588] - Review comments and made some minor UX changes to the component * Updated stylings * upcoming: [DI-22588] - UX changes * upcoming: [DI-22588] - Fixed the validation error resolution for Metric Data Field and Dimension Filter Data Field * upcoming: [DI-22588] - Review changes * upcoming: [DI-22588] - Moved mockData to individual test files instead of exporting to fix the failing tests * upcoming: [DI-22558] - Typescript issue fixes * Update constants.ts --------- Co-authored-by: nikhagra-akamai <nagrawal@akamai.com> Co-authored-by: vmangalr <vmangalr@akamai.com> Co-authored-by: venkatmano-akamai <chk-Venkatesh@outlook.com>

upcoming: [DI-22558] - Added Trigger condition and Dimension Filter c…

d17769e

…hanges

santoshp210-akamai self-assigned this Dec 19, 2024

santoshp210-akamai added 4 commits December 20, 2024 01:41

removed unnecessary console log statement

856c0dc

upcoming: [DI-22558] - Importing right interface for Trigger conditio…

e661920

…n for error validation and minor changes

upcoming: [DI-22588] - Added the Unit Tests for the components

4a5fd77

upcoming: [DI-22588] - Added changesets and few changes to the messag…

76374d3

…es in validation schema

santoshp210-akamai marked this pull request as ready for review December 20, 2024 15:01

santoshp210-akamai requested a review from a team as a code owner December 20, 2024 15:01

santoshp210-akamai requested review from hkhalil-akamai and pmakode-akamai and removed request for a team December 20, 2024 15:01

jaalah-akamai requested a review from bnussman-akamai December 23, 2024 21:30

jaalah-akamai reviewed Dec 23, 2024

View reviewed changes

upcoming: [DI-22588] - Review comments and made some minor UX changes…

d82bdf4

… to the component

nikhagra-akamai and others added 3 commits December 27, 2024 17:26

Updated stylings

0f2d5a8

Merge pull request #50 from nikhagra-akamai/css-fix

6fbe887

Updated stylings

upcoming: [DI-22588] - UX changes

beb6e51

santoshp210-akamai requested review from jaalah-akamai December 27, 2024 14:28

upcoming: [DI-22588] - Fixed the validation error resolution for Metr…

e364d1d

…ic Data Field and Dimension Filter Data Field

santoshp210-akamai requested a review from a team as a code owner December 30, 2024 06:34

santoshp210-akamai requested review from AzureLatte and removed request for a team December 30, 2024 06:34

santoshp210-akamai force-pushed the feature/create-alert-form-dimension-filters-and-trigger-conditions branch from 34d575b to e364d1d Compare December 30, 2024 07:27

santoshp210-akamai added 2 commits December 30, 2024 18:30

upcoming: [DI-22588] - Review changes

74fa243

upcoming: [DI-22588] - Moved mockData to individual test files instea…

f20078a

…d of exporting to fix the failing tests

santoshp210-akamai force-pushed the feature/create-alert-form-dimension-filters-and-trigger-conditions branch from fb29615 to f20078a Compare December 31, 2024 05:30

vmangalr and others added 3 commits January 2, 2025 12:08

Merge branch 'develop' of https://github.com/linode/manager into sant…

428aed3

…osh_type_fixes

upcoming: [DI-22558] - Typescript issue fixes

bdf03b0

Merge pull request #52 from venkymano-akamai/santosh_type_fixes

7ffc07a

Merge latest linode develop and type changes

bnussman-akamai approved these changes Jan 2, 2025

View reviewed changes

jaalah-akamai approved these changes Jan 3, 2025

View reviewed changes

jaalah-akamai added Approved Multiple approvals and ready to merge! Cloud Pulse Cloud Pulse - Alerting labels Jan 3, 2025

santoshp210-akamai added 2 commits January 6, 2025 13:42

Merge branch 'develop' into feature/create-alert-form-dimension-filte…

12729a1

…rs-and-trigger-conditions

Update constants.ts

6fa3994

jaalah-akamai merged commit b47661f into linode:develop Jan 7, 2025
22 of 23 checks passed

This was referenced Jan 8, 2025

Release v1.134.0 - release → staging #11494

Closed

Release v1.134.0 - release → staging #11497

Merged

hana-akamai mentioned this pull request Jan 9, 2025

Release v1.134.0 - release → staging #11503

Merged

jaalah-akamai mentioned this pull request Jan 14, 2025

Release v1.134.0 - staging → master #11519

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [DI-22558] - Added Trigger condition and Dimension Filter components #11445

upcoming: [DI-22558] - Added Trigger condition and Dimension Filter components #11445

santoshp210-akamai commented Dec 19, 2024 •

edited

Loading

jaalah-akamai left a comment

santoshp210-akamai commented Dec 24, 2024 •

edited

Loading

santoshp210-akamai commented Dec 24, 2024

bnussman-akamai commented Dec 24, 2024

santoshp210-akamai commented Dec 24, 2024

jaalah-akamai commented Dec 26, 2024 •

edited

Loading

santoshp210-akamai commented Dec 27, 2024

github-actions bot commented Dec 30, 2024 •

edited

Loading

linode-gh-bot commented Jan 6, 2025

cypress bot commented Jan 7, 2025 •

edited

Loading

upcoming: [DI-22558] - Added Trigger condition and Dimension Filter components #11445

upcoming: [DI-22558] - Added Trigger condition and Dimension Filter components #11445

Conversation

santoshp210-akamai commented Dec 19, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

jaalah-akamai left a comment

Choose a reason for hiding this comment

santoshp210-akamai commented Dec 24, 2024 • edited Loading

santoshp210-akamai commented Dec 24, 2024

bnussman-akamai commented Dec 24, 2024

santoshp210-akamai commented Dec 24, 2024

jaalah-akamai commented Dec 26, 2024 • edited Loading

santoshp210-akamai commented Dec 27, 2024

github-actions bot commented Dec 30, 2024 • edited Loading

linode-gh-bot commented Jan 6, 2025

Cloud Manager UI test results

🎉 471 passing tests on test run #18 ↗︎

cypress bot commented Jan 7, 2025 • edited Loading

Cloud Manager E2E Run #7052

Tests for review

santoshp210-akamai commented Dec 19, 2024 •

edited

Loading

santoshp210-akamai commented Dec 24, 2024 •

edited

Loading

jaalah-akamai commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 30, 2024 •

edited

Loading

cypress bot commented Jan 7, 2025 •

edited

Loading