[BREAKING] chore(core): remove moment and date-picker utils #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcornut
force-pushed
the
feat/remove-moment
branch
from
fa801f3 to
a137ba5
Compare
gcornut
force-pushed
the
chore/remove-moment
branch
from
26693c0 to
ad6c462
Compare
gcornut
changed the title
gcornut
changed the title
gcornut
force-pushed
the
chore/remove-moment
branch
from
ad6c462 to
74fc923
Compare
gcornut
force-pushed
the
feat/remove-moment
branch
3 times, most recently
from
7259230 to
b8cc29a
Compare
gcornut
force-pushed
the
chore/remove-moment
branch
from
74fc923 to
3ee14b7
Compare
gcornut
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR removed all use of the moment lib (date picker) and deprecated exported utility functions that used moment: #1013
Now this PR actually removes moment:
momentandmoment-rangefrom@lumx/core@lumx/core/js/date-pickerutility function (last code that use moment)This PR will require us to release a major version after merge