Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] chore(core): remove moment and date-picker utils #1016

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[BREAKING] chore(core): remove moment and date-picker utils #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Removed

- _[BREAKING]_ `@lumx/core/js/utils/date-picker` date util functions have been removed, replaced with internal utils (not using moment anymore)

### Changed

- `@lumx/react` no long depend on `moment` or `moment-range` to generate the date picker.
Expand Down
4 changes: 0 additions & 4 deletions packages/lumx-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,5 @@
"webpack": "^4.44.1",
"webpack-notifier": "^1.8.0",
"webpackbar": "^4.0.0"
},
"peerDependencies": {
"moment": ">= 2",
"moment-range": "^4.0.2"
}
}
77 changes: 0 additions & 77 deletions packages/lumx-core/src/js/date-picker.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/lumx-core/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ module.exports = {
),
},

externals: ['moment', 'moment-range'],
externals: [],

bail: true,
devtool: 'source-map',
Expand Down
2 changes: 0 additions & 2 deletions packages/site-demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@
"intersection-observer": "^0.7.0",
"lodash": "4.17.21",
"lunr": "^2.3.9",
"moment": "^2.29.4",
"moment-range": "^4.0.2",
"prism-react-renderer": "^0.1.5",
"prismjs": "^1.25.0",
"react": "^17.0.2",
Expand Down
20 changes: 2 additions & 18 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6100,9 +6100,6 @@ __metadata:
webpack: ^4.44.1
webpack-notifier: ^1.8.0
webpackbar: ^4.0.0
peerDependencies:
moment: ">= 2"
moment-range: ^4.0.2
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -15357,7 +15354,7 @@ __metadata:
languageName: node
linkType: hard

"es6-symbol@npm:^3.1.0, es6-symbol@npm:^3.1.1, es6-symbol@npm:~3.1.2":
"es6-symbol@npm:^3.1.1, es6-symbol@npm:~3.1.2":
version: 3.1.3
resolution: "es6-symbol@npm:3.1.3"
dependencies:
Expand Down Expand Up @@ -23889,8 +23886,6 @@ fsevents@~2.1.2:
intersection-observer: ^0.7.0
lodash: 4.17.21
lunr: ^2.3.9
moment: ^2.29.4
moment-range: ^4.0.2
prism-react-renderer: ^0.1.5
prismjs: ^1.25.0
react: ^17.0.2
Expand Down Expand Up @@ -25016,18 +25011,7 @@ fsevents@~2.1.2:
languageName: node
linkType: hard

"moment-range@npm:^4.0.2":
version: 4.0.2
resolution: "moment-range@npm:4.0.2"
dependencies:
es6-symbol: ^3.1.0
peerDependencies:
moment: ">= 2"
checksum: ff7425eed2600b1450ae25a7d074fb1edbc7956199f9eca974d5b2bc7885912dd08205e55675eb1b8cbbdcb3647622748861822580bd7327e680ca2202f8ee31
languageName: node
linkType: hard

"moment@npm:^2.27.0, moment@npm:^2.29.4":
"moment@npm:^2.27.0":
version: 2.29.4
resolution: "moment@npm:2.29.4"
checksum: 0ec3f9c2bcba38dc2451b1daed5daded747f17610b92427bebe1d08d48d8b7bdd8d9197500b072d14e326dd0ccf3e326b9e3d07c5895d3d49e39b6803b76e80e
Expand Down