-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adds recent GH + CodeRabbit configs #29
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,90 @@ | ||
# Docs: https://docs.coderabbit.ai/configure-coderabbit | ||
# Schema: https://coderabbit.ai/integrations/schema.v2.json | ||
# Support: https://discord.gg/GsXnASn26c | ||
|
||
language: en | ||
|
||
tone_instructions: | | ||
Provide feedback in a professional, friendly, constructive, and concise tone. | ||
Offer clear, specific suggestions and best practices to help enhance the code quality and promote learning. | ||
|
||
early_access: true | ||
|
||
knowledge_base: | ||
# The scope of learnings to use for the knowledge base. | ||
# `local` uses the repository's learnings, | ||
# `global` uses the organization's learnings, | ||
# `auto` uses repository's learnings for public repositories and organization's learnings for private repositories. | ||
# Default value: `auto` | ||
learnings: | ||
scope: global | ||
issues: | ||
scope: global | ||
pull_requests: | ||
scope: global | ||
|
||
reviews: | ||
profile: chill | ||
auto_review: | ||
# Ignore reviewing if the title of the pull request contains any of these keywords (case-insensitive) | ||
ignore_title_keywords: | ||
- wip | ||
- draft | ||
- test | ||
# Set the commit status to 'pending' when the review is in progress and 'success' when it is complete. | ||
commit_status: false | ||
# Post review details on each review. Additionally, post a review status when a review is skipped in certain cases. | ||
review_status: false | ||
path_instructions: | ||
- path: "**/*.tf" | ||
instructions: | | ||
You're a Terraform expert who has thoroughly studied all the documentation from Hashicorp https://developer.hashicorp.com/terraform/docs and OpenTofu https://opentofu.org/docs/. | ||
You have a strong grasp of Terraform syntax and prioritize providing accurate and insightful code suggestions. | ||
As a fan of the Cloud Posse / SweetOps ecosystem, you incorporate many of their best practices https://docs.cloudposse.com/best-practices/terraform/ while balancing them with general Terraform guidelines. | ||
tools: | ||
# By default, all tools are enabled. | ||
# Masterpoint uses Trunk (https://trunk.io) so we do not need a lot of this feedback due to overlap. | ||
shellcheck: | ||
enabled: false | ||
ruff: | ||
enabled: false | ||
markdownlint: | ||
enabled: false | ||
github-checks: | ||
enabled: false | ||
languagetool: | ||
enabled: false | ||
biome: | ||
enabled: false | ||
hadolint: | ||
enabled: false | ||
swiftlint: | ||
enabled: false | ||
phpstan: | ||
enabled: false | ||
golangci-lint: | ||
enabled: false | ||
yamllint: | ||
enabled: false | ||
gitleaks: | ||
enabled: false | ||
checkov: | ||
enabled: false | ||
detekt: | ||
enabled: false | ||
eslint: | ||
enabled: false | ||
rubocop: | ||
enabled: false | ||
buf: | ||
enabled: false | ||
regal: | ||
enabled: false | ||
actionlint: | ||
enabled: false | ||
pmd: | ||
enabled: false | ||
cppcheck: | ||
enabled: false | ||
circleci: | ||
enabled: false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Lint | ||
|
||
concurrency: | ||
group: lint-${{ github.head_ref || github.run_id }} | ||
cancel-in-progress: true | ||
|
||
on: pull_request | ||
|
||
permissions: | ||
actions: read | ||
checks: write | ||
contents: read | ||
pull-requests: read | ||
|
||
jobs: | ||
trunk-check: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check out Git repository | ||
uses: actions/checkout@v4 | ||
- name: Trunk Check | ||
uses: trunk-io/trunk-action@4d5ecc89b2691705fd08c747c78652d2fc806a94 # v1.1.19 | ||
|
||
conventional-title: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: amannn/action-semantic-pull-request@0723387faaf9b38adef4775cd42cfd5155ed6017 # v5.5.3 | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
name: Release Please | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
|
||
permissions: | ||
contents: write | ||
pull-requests: write | ||
|
||
jobs: | ||
release-please: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: googleapis/release-please-action@7987652d64b4581673a76e33ad5e98e3dd56832f | ||
with: | ||
release-type: terraform-module |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
name: Monthly Trunk Upgrade | ||
on: | ||
schedule: | ||
# On the first day of every month @ 8am | ||
- cron: 0 8 1 * * | ||
# Allows us to manually run the workflow from Actions UI | ||
workflow_dispatch: {} | ||
permissions: read-all | ||
jobs: | ||
trunk_upgrade: | ||
name: Upgrade Trunk | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write # For trunk to create PRs | ||
pull-requests: write # For trunk to create PRs | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v4 | ||
|
||
- name: Trunk Upgrade | ||
uses: trunk-io/trunk-action/upgrade@2eaee169140ec559bd556208f9f99cdfdf468da8 # v1.1.18 | ||
with: | ||
base: main | ||
reviewers: "@masterpointio/masterpoint-internal" | ||
prefix: "chore: " |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,3 +34,6 @@ override.tf.json | |
|
||
# Ignore lock files | ||
.terraform.lock.hcl | ||
|
||
# Random | ||
*.DS_Store |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ data "aws_ami" "amazon_linux_2023" { | |
|
||
filter { | ||
name = "name" | ||
values = ["al2023-ami*"] | ||
values = ["amzn2-ami-hvm-2.0.*"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm confused about this one. AL2 is OLDER than AL2023. Why are we needing to revert back? Can you explain what the issue was and where you found it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The issue was that the fetched AMI didn't contain SSM agent. |
||
} | ||
|
||
filter { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 - this is the only thing to review.