task solution #2686
Open
task solution #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitaliyBodnar
suggested changes
Oct 24, 2023
src/convertToObject.js
Outdated
Comment on lines
25
to
26
| const property = parts[0]; | ||
| const value = parts[1]; |
There was a problem hiding this comment.
it's better to use arrays destructuring as it will make a code shorter
Suggested change
| const property = parts[0]; | |
| const value = parts[1]; | |
| const [property, value] = parts; |
etojeDenys
suggested changes
Oct 25, 2023
src/convertToObject.js
Outdated
| * | ||
| * @param {string} sourceString | ||
| * | ||
| * @return {object} | ||
| */ | ||
| function convertToObject(sourceString) { | ||
| // write your code here | ||
| const cssObject = {}; | ||
| const lines = sourceString.split('\n'); |
There was a problem hiding this comment.
we can simplify the logic and split by the ;
|
like that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.