Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task solution #2686

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions src/convertToObject.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,39 @@
/**
* Implement convertToObject function:
*
* Function takes a string with styles (see an example in [stylesString.js](./stylesString.js))
* and returns an object where CSS properties are keys
* and values are the values of related CSS properties (see an exampl in [test file](./convertToObject.test.js))
* Function takes a string with styles
* (see an example in [stylesString.js](./stylesString.js))
* and returns an object where
* CSS properties are keys
* and values are the values of related CSS properties
* (see an exampl in [test file](./convertToObject.test.js))
*
* @param {string} sourceString
*
* @return {object}
*/
function convertToObject(sourceString) {
// write your code here
const cssObject = {};
const lines = sourceString.split('\n');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can simplify the logic and split by the ;


for (const line of lines) {
const parts = line.split(':');

if (parts.length === 2) {
const property = parts[0];
const value = parts[1];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to use arrays destructuring as it will make a code shorter

Suggested change
const property = parts[0];
const value = parts[1];
const [property, value] = parts;


const trimmedProperty = property.trim();
const trimmedValue = value
.replace(/\s+/g, ' ')
.replace(/;$/, '')
.trim();

cssObject[trimmedProperty] = trimmedValue;
}
}

return cssObject;
}

module.exports = convertToObject;
Loading