implemented class ArrayList #1201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rommelua
suggested changes
Oct 29, 2023
Comment on lines
35
to
40
| growIfArrayFull(); | ||
| for (int i = 0; i < list.size(); i++) { | ||
| growIfArrayFull(); | ||
| this.elementData[size] = list.get(i); | ||
| size++; | ||
| } |
There was a problem hiding this comment.
Suggested change
| growIfArrayFull(); | |
| for (int i = 0; i < list.size(); i++) { | |
| growIfArrayFull(); | |
| this.elementData[size] = list.get(i); | |
| size++; | |
| } | |
| for (int i = 0; i < list.size(); i++) { | |
| add(list.get(i)); | |
| } |
Comment on lines
45
to
47
| if (index < 0 || index >= size) { | ||
| throw new ArrayListIndexOutOfBoundsException("incorrect index"); | ||
| } |
| return size == 0; | ||
| } | ||
|
|
||
| public int index(T element) { |
There was a problem hiding this comment.
Suggested change
| public int index(T element) { | |
| private int getIndex(T element) { |
| public class ArrayList<T> implements List<T> { | ||
| private static final int DEFAULT_CAPACITY = 10; | ||
| private static final double MIN_CAPACITY = 1.5; |
There was a problem hiding this comment.
it is not MIN_CAPACITY - think about name
Rommelua
approved these changes
Oct 30, 2023
| } | ||
| } | ||
|
|
||
| private void indexChecker(int index) { |
There was a problem hiding this comment.
Suggested change
| private void indexChecker(int index) { | |
| private void checkIndex(int index) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.