Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented class ArrayList #1201

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 68 additions & 9 deletions src/main/java/core/basesyntax/ArrayList.java
Original file line number Diff line number Diff line change
@@ -1,48 +1,107 @@
package core.basesyntax;

import java.util.NoSuchElementException;

public class ArrayList<T> implements List<T> {
private static final int DEFAULT_CAPACITY = 10;
private static final double MIN_CAPACITY = 1.5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not MIN_CAPACITY - think about name

private Object[] elementData;
private int size;

public ArrayList() {
elementData = new Object[DEFAULT_CAPACITY];
}

@Override
public void add(T value) {

growIfArrayFull();
elementData[size] = value;
size++;
}

@Override
public void add(T value, int index) {

if (index < 0 || index > size) {
throw new ArrayListIndexOutOfBoundsException("incorrect index");
}
growIfArrayFull();
System.arraycopy(elementData, index, elementData, index + 1, size - index);
elementData[index] = value;
size++;
}

@Override
public void addAll(List<T> list) {

growIfArrayFull();
for (int i = 0; i < list.size(); i++) {
growIfArrayFull();
this.elementData[size] = list.get(i);
size++;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
growIfArrayFull();
for (int i = 0; i < list.size(); i++) {
growIfArrayFull();
this.elementData[size] = list.get(i);
size++;
}
for (int i = 0; i < list.size(); i++) {
add(list.get(i));
}

}

@Override
public T get(int index) {
return null;
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("incorrect index");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

return (T) elementData[index];
}

@Override
public void set(T value, int index) {

if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("incorrect index");
}
elementData[index] = value;
}

@Override
public T remove(int index) {
return null;
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("incorrect index");
}
Object removedElement = elementData[index];
System.arraycopy(elementData, index + 1, elementData, index, size - index - 1);
size--;
return (T) removedElement;
}

@Override
public T remove(T element) {
return null;
int position = index(element);
if (position < 0) {
throw new NoSuchElementException("element does not exist");
}
Object removedElement = remove(position);
return (T) removedElement;
}

@Override
public int size() {
return 0;
return size;
}

@Override
public boolean isEmpty() {
return false;
return size == 0;
}

public int index(T element) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public int index(T element) {
private int getIndex(T element) {

for (int i = 0; i < size; i++) {
if ((element == elementData[i])
|| (element != null && element.equals(elementData[i]))) {
return i;
}
}
return -1;
}

private void growIfArrayFull() {
if (elementData.length == size) {
Object[] newArray = new Object[(int) (elementData.length * MIN_CAPACITY)];
System.arraycopy(elementData, 0, newArray, 0, size);
elementData = newArray;
}
}
}
Loading