created own ArrayList collection which implements our List interface … #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and uses custom exeption
Rommelua
suggested changes
Nov 8, 2023
| this.elements = new Object[DEFAULT_CAPACITY]; | ||
| } | ||
|
|
||
| private void ensureCapacity() { |
There was a problem hiding this comment.
Private ones (methods, classes) should be after public ones.
| private void ensureCapacity() { | ||
| if (size == elements.length) { | ||
| int newCapacity = (int) (elements.length * 1.5); | ||
| elements = Arrays.copyOf(elements, newCapacity); |
Ivan95kos
suggested changes
Nov 8, 2023
| public class ArrayList<T> implements List<T> { | ||
| private static final int DEFAULT_CAPACITY = 10; | ||
| private static final double RESIZE_COEFFICIENT = 1.5; | ||
| private Object[] elements; |
There was a problem hiding this comment.
use the parameterized type
Suggested change
| private Object[] elements; | |
| private T [] elements; |
Comment on lines
43
to
47
| if (index < 0 || index >= size) { | ||
| throw new ArrayListIndexOutOfBoundsException("Index outed of bounds, Index: " + index | ||
| + ", Size: " | ||
| + size); | ||
| } |
There was a problem hiding this comment.
move this check to the private method
you use it several times
Comment on lines
76
to
90
| if (element == null) { | ||
| for (int i = 0; i < size; i++) { | ||
| if (elements[i] == null) { | ||
| return remove(i); | ||
| } | ||
| } | ||
| throw new NoSuchElementException("Element not found"); | ||
| } | ||
|
|
||
| for (int i = 0; i < size; i++) { | ||
| if (element.equals(elements[i])) { | ||
| return remove(i); | ||
| } | ||
| } | ||
| throw new NoSuchElementException("Element not found"); |
kozhukhovsky
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and uses custom exeption