Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created own ArrayList collection which implements our List interface … #1216

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 76 additions & 9 deletions src/main/java/core/basesyntax/ArrayList.java
Original file line number Diff line number Diff line change
@@ -1,48 +1,115 @@
package core.basesyntax;

import java.util.NoSuchElementException;

public class ArrayList<T> implements List<T> {
private static final int DEFAULT_CAPACITY = 10;
private static final double RESIZE_COEFFICIENT = 1.5;
private Object[] elements;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the parameterized type

Suggested change
private Object[] elements;
private T [] elements;

private int size;

public ArrayList() {
this.elements = new Object[DEFAULT_CAPACITY];
}

@Override
public void add(T value) {

ensureCapacity();
elements[size++] = value;
}

@Override
public void add(T value, int index) {

if (index < 0 || index > size) {
throw new ArrayListIndexOutOfBoundsException("Index outed of bounds, Index: " + index
+ ", Size: "
+ size);
}
ensureCapacity();
System.arraycopy(elements, index, elements, index + 1, size - index);
elements[index] = value;
size++;
}

@Override
public void addAll(List<T> list) {

for (int i = 0; i < list.size(); i++) {
add(list.get(i));
}
}

@Override
public T get(int index) {
return null;
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("Index outed of bounds, Index: " + index
+ ", Size: "
+ size);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this check to the private method
you use it several times

return (T) elements[index];
}

@Override
public void set(T value, int index) {

if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("Index outed of bounds, Index: " + index
+ ", Size: "
+ size);
}
elements[index] = value;
}

@Override
public T remove(int index) {
return null;
if (index < 0 || index >= size) {
throw new ArrayListIndexOutOfBoundsException("Index outed of bounds, Index: " + index
+ ", Size: "
+ size);
}
T removedValue = (T) elements[index];
System.arraycopy(elements, index + 1, elements, index, size - index - 1);
elements[--size] = null;
return removedValue;
}

@Override
public T remove(T element) {
return null;
if (element == null) {
for (int i = 0; i < size; i++) {
if (elements[i] == null) {
return remove(i);
}
}
throw new NoSuchElementException("Element not found");
}

for (int i = 0; i < size; i++) {
if (element.equals(elements[i])) {
return remove(i);
}
}
throw new NoSuchElementException("Element not found");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the one loop here

}

@Override
public int size() {
return 0;
return size;
}

@Override
public boolean isEmpty() {
return false;
return size == 0;
}

private void resize() {
int newCapacity = (int) (elements.length * RESIZE_COEFFICIENT);
Object[] newElements = new Object[newCapacity];
System.arraycopy(elements, 0, newElements, 0, size);
elements = newElements;
}

private void ensureCapacity() {
if (size == elements.length) {
resize();
}
}
}
Loading