implemented all methods of StreamPractice according to task #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/practice/StreamPractice.java
bhdnchui
suggested changes
Oct 30, 2023
Comment on lines
25
to
26
| return Integer.parseInt(periodLength[1]) | ||
| - Integer.parseInt(periodLength[0]) >= MIN_PERIOD_OF_LIVING; |
Comment on lines
25
to
26
| return Integer.parseInt(periodLength[1]) | ||
| - Integer.parseInt(periodLength[0]) >= MIN_PERIOD_OF_LIVING; |
There was a problem hiding this comment.
Suggested change
| return Integer.parseInt(periodLength[1]) | |
| - Integer.parseInt(periodLength[0]) >= MIN_PERIOD_OF_LIVING; | |
| int yearsInUkraine = Integer.parseInt(periodLength[1]) - Integer.parseInt(periodLength[0]); | |
| return yearsInUkraine >= MIN_PERIOD_OF_LIVING; |
| } | ||
|
|
||
| private boolean hasTenYearsPeriodOfLivingInUkraine(String period) { | ||
| String[] periodLength = period.split(SPLIT_REGEX); |
| boolean isAllowedToVote = candidate.isAllowedToVote(); | ||
| boolean isNationalityAllowed = candidate.getNationality().equals(REQUIRED_NATIONALITY); | ||
| boolean isLivingTenYearsInUkraine | ||
| = hasTenYearsPeriodOfLivingInUkraine(candidate.getPeriodsInUkr()); |
| }) | ||
| .filter(i -> i % 2 != 0) | ||
| .average() | ||
| .orElseThrow(NoSuchElementException::new); |
There was a problem hiding this comment.
If you need to throw exception when no result found after stream execution sometimes get()/getAsDouble() may help, try to google what does it do.
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> validatePerson(p, fromAge, maleToAge, femaleToAge)) | ||
| .collect(Collectors.toList()); |
| .filter(p -> p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge) | ||
| .flatMap(p -> p.getCats().stream()) | ||
| .map(Cat::getName) | ||
| .collect(Collectors.toList()); |
| public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||
| return Collections.emptyList(); | ||
| return peopleList.stream() | ||
| .filter(p -> p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge) |
There was a problem hiding this comment.
Suggested change
| .filter(p -> p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge) | |
| .filter(p -> Person.Sex.WOMAN.equals(p.getSex()) && p.getAge() >= femaleAge) |
Plus, one-letter names
| .filter(validator) | ||
| .map(Candidate::getName) | ||
| .sorted() | ||
| .collect(Collectors.toList()); |
Comment on lines
72
to
75
| return person.getSex() == Person.Sex.MAN | ||
| && person.getAge() >= fromAge && person.getAge() <= maleToAge | ||
| || person.getSex() == Person.Sex.WOMAN | ||
| && person.getAge() >= fromAge && person.getAge() <= femaleToAge; |
There was a problem hiding this comment.
You call getAge 4 times and getSex 2 times, avoid it.
Enum comparison.
# Conflicts: # src/main/java/practice/StreamPractice.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.