Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented all methods of StreamPractice according to task #922

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/main/java/practice/CandidateValidator.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
package practice;

public class CandidateValidator {
//write your code here
import java.util.function.Predicate;
import model.Candidate;

public class CandidateValidator implements Predicate<Candidate> {
private static final int MIN_AGE = 35;
private static final String REQUIRED_NATIONALITY = "Ukrainian";
private static final String SPLIT_REGEX = "-";
private static final int MIN_PERIOD_OF_LIVING = 10;

@Override
public boolean test(Candidate candidate) {
boolean isAgeAllowed = candidate.getAge() >= MIN_AGE;
boolean isAllowedToVote = candidate.isAllowedToVote();
boolean isNationalityAllowed = candidate.getNationality().equals(REQUIRED_NATIONALITY);
boolean isLivingTenYearsInUkraine
= hasTenYearsPeriodOfLivingInUkraine(candidate.getPeriodsInUkr());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify method name?


return isAgeAllowed && isNationalityAllowed && isAllowedToVote && isLivingTenYearsInUkraine;
}

private boolean hasTenYearsPeriodOfLivingInUkraine(String period) {
String[] periodLength = period.split(SPLIT_REGEX);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to find better name.

return Integer.parseInt(periodLength[1])
- Integer.parseInt(periodLength[0]) >= MIN_PERIOD_OF_LIVING;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make constant for indexes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return Integer.parseInt(periodLength[1])
- Integer.parseInt(periodLength[0]) >= MIN_PERIOD_OF_LIVING;
int yearsInUkraine = Integer.parseInt(periodLength[1]) - Integer.parseInt(periodLength[0]);
return yearsInUkraine >= MIN_PERIOD_OF_LIVING;

}
}
105 changes: 51 additions & 54 deletions src/main/java/practice/StreamPractice.java
Original file line number Diff line number Diff line change
@@ -1,80 +1,77 @@
package practice;

import java.util.Collections;
import java.util.Arrays;
import java.util.List;
import java.util.NoSuchElementException;
import java.util.stream.Collectors;
import java.util.stream.IntStream;
import model.Candidate;
import model.Cat;
import model.Person;

public class StreamPractice {
/**
* Given list of strings where each element contains 1+ numbers:
* input = {"5,30,100", "0,22,7", ...}
* return min integer value. One more thing - we're interested in even numbers.
* If there is no needed data throw RuntimeException with message
* "Can't get min value from list: < Here is our input 'numbers' >"
*/
private static final String SPLIT_STRING_REGEX = ",";

public int findMinEvenNumber(List<String> numbers) {
return 0;
return numbers.stream()
.map(string -> string.split(SPLIT_STRING_REGEX))
.flatMap(Arrays::stream)
.mapToInt(Integer::parseInt)
.filter(i -> i % 2 == 0)
.min()
.orElseThrow(() -> new RuntimeException("Can't get min value from list: "
+ numbers));
}

/**
* Given a List of Integer numbers,
* return the average of all odd numbers from the list or throw NoSuchElementException.
* But before that subtract 1 from each element on an odd position (having the odd index).
*/
public Double getOddNumsAverage(List<Integer> numbers) {
return 0D;
System.out.println(numbers);
return IntStream.range(0, numbers.size())
.map(i -> {
if (i % 2 == 0) {
return numbers.get(i);
}
return numbers.get(i) - 1;
})
.filter(i -> i % 2 != 0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont use one-letter names.
Use ternary operator here.
Avoid duplication of code that checks even or odd is a number.

.average()
.orElseThrow(NoSuchElementException::new);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you need to throw exception when no result found after stream execution sometimes get()/getAsDouble() may help, try to google what does it do.

}

/**
* Given a List of `Person` instances (having `name`, `age` and `sex` fields),
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN),
* new Person(«Helen», 42, Sex.WOMAN))`,
* select from the List only men whose age is from `fromAge` to `toAge` inclusively.
* <p>
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively).
*/
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getSex() == Person.Sex.MAN
&& p.getAge() >= fromAge && p.getAge() <= toAge)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pay attention to what is a better way to compare Enum values: equals() vs == ?
Make variable to avoid double getAge method call.
Dont use one-letter names.

.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.collect(Collectors.toList());
.toList();

}

/**
* Given a List of `Person` instances (having `name`, `age` and `sex` fields),
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN),
* new Person(«Helen», 42, Sex.WOMAN))`,
* select from the List only people whose age is from `fromAge` and to `maleToAge` (for men)
* or to `femaleToAge` (for women) inclusively.
* <p>
* Example: select people of working age
* (from 18 y.o. and to 60 y.o. for men and to 55 y.o. for women inclusively).
*/
public List<Person> getWorkablePeople(int fromAge, int femaleToAge,
int maleToAge, List<Person> peopleList) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> validatePerson(p, fromAge, maleToAge, femaleToAge))
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

}

/**
* Given a List of `Person` instances (having `name`, `age`, `sex` and `cats` fields,
* and each `Cat` having a `name` and `age`),
* return the names of all cats whose owners are women from `femaleAge` years old inclusively.
*/
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) {
return Collections.emptyList();
return peopleList.stream()
.filter(p -> p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.filter(p -> p.getSex().equals(Person.Sex.WOMAN) && p.getAge() >= femaleAge)
.filter(p -> Person.Sex.WOMAN.equals(p.getSex()) && p.getAge() >= femaleAge)

Plus, one-letter names

.flatMap(p -> p.getCats().stream())
.map(Cat::getName)
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

}

/**
* Your help with a election is needed. Given list of candidates, where each element
* has Candidate.class type.
* Check which candidates are eligible to apply for president position and return their
* names sorted alphabetically.
* The requirements are: person should be older than 35 years, should be allowed to vote,
* have nationality - 'Ukrainian'
* and live in Ukraine for 10 years. For the last requirement use field periodsInUkr,
* which has following view: "2002-2015"
* We want to reuse our validation in future, so let's write our own impl of Predicate
* parametrized with Candidate in CandidateValidator.
*/
public List<String> validateCandidates(List<Candidate> candidates) {
return Collections.emptyList();
CandidateValidator validator = new CandidateValidator();
return candidates.stream()
.filter(validator)
.map(Candidate::getName)
.sorted()
.collect(Collectors.toList());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

}

private boolean validatePerson(Person person, int fromAge, int maleToAge, int femaleToAge) {
return person.getSex() == Person.Sex.MAN
&& person.getAge() >= fromAge && person.getAge() <= maleToAge
|| person.getSex() == Person.Sex.WOMAN
&& person.getAge() >= fromAge && person.getAge() <= femaleToAge;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You call getAge 4 times and getSex 2 times, avoid it.
Enum comparison.

}
}
Loading