stream-github-practice solution #924
Conversation
| return peopleList.stream() | ||
| .filter(person -> person.getAge() >= fromAge | ||
| && person.getAge() <= toAge | ||
| && person.getSex() == Person.Sex.MAN) | ||
| .toList(); |
There was a problem hiding this comment.
I think here you could split all statements in different filters to make it look less complicated
| public List<String> validateCandidates(List<Candidate> candidates) { | ||
| return Collections.emptyList(); | ||
| CandidateValidator candidateValidator = new CandidateValidator(); |
There was a problem hiding this comment.
It's better when you create validator on class level, not when method calls
|
|
||
| @Override | ||
| public boolean test(Candidate candidate) { | ||
| String[] splitCandidate = candidate.getPeriodsInUkr().split(SEPARATION_MARK); |
| int yearsInUkr = Arrays.stream(splitCandidate) | ||
| .map(String::trim) | ||
| .map(Integer::parseInt) | ||
| .reduce((a, b) -> b - a) | ||
| .orElse(0); |
| .orElse(0); | ||
| return candidate.getAge() >= MIN_AGE | ||
| && candidate.isAllowedToVote() | ||
| && candidate.getNationality().equals(NATIONALITY) |
There was a problem hiding this comment.
| && candidate.getNationality().equals(NATIONALITY) | |
| && NATIONALITY.equals(candidate.getNationality()) |
| public int findMinEvenNumber(List<String> numbers) { | ||
| return 0; | ||
| return numbers.stream() | ||
| .map(split -> split.split(",")) |
| .sorted() | ||
| .findFirst() |
There was a problem hiding this comment.
| .sorted() | |
| .findFirst() | |
| .min() |
| List<Integer> filterListNumbers = IntStream.range(0, numbers.size()) | ||
| .mapToObj(i -> i % 2 == 1 ? numbers.get(i) - 1 : numbers.get(i)) | ||
| .toList(); | ||
| return filterListNumbers.stream() | ||
| .filter(num -> num % 2 == 1) |
There was a problem hiding this comment.
Let's make it with one stream.
Dont use one-letter names.
Avoid duplication of code that checks even or odd is a number.
| Predicate<Person> predicate = person -> person.getAge() >= fromAge | ||
| && person.getAge() <= toAge | ||
| && person.getSex() == Person.Sex.MAN; |
There was a problem hiding this comment.
Make variables to avoid double getAge() method call
Pay attention to what is a better way to compare Enum values: equals() vs == ?
| if (person.getAge() >= fromAge) { | ||
| if (person.getSex() == Person.Sex.WOMAN && person.getAge() <= femaleToAge) { | ||
| return true; | ||
| } | ||
| return person.getSex() == Person.Sex.MAN && person.getAge() <= maleToAge; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Make variables to avoid double getAge() and getSex() methods calls
Pay attention to what is a better way to compare Enum values: equals() vs == ?
| return Collections.emptyList(); | ||
|
|
||
| return peopleList.stream() | ||
| .filter(women -> women.getSex() == Person.Sex.WOMAN && women.getAge() >= femaleAge) |
There was a problem hiding this comment.
| .filter(new CandidateValidator()) | ||
| .map(Candidate::getName) | ||
| .sorted() | ||
| .collect(Collectors.toList()); |
There was a problem hiding this comment.
| .collect(Collectors.toList()); | |
| .toList(); |
No description provided.