-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream-github-practice solution #924
base: main
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,5 +1,26 @@ | ||||||
package practice; | ||||||
|
||||||
public class CandidateValidator { | ||||||
//write your code here | ||||||
import java.util.Arrays; | ||||||
import java.util.function.Predicate; | ||||||
import model.Candidate; | ||||||
|
||||||
public class CandidateValidator implements Predicate<Candidate> { | ||||||
private static final String SEPARATION_MARK = "-"; | ||||||
private static final String NATIONALITY = "Ukrainian"; | ||||||
private static final int MIN_AGE = 35; | ||||||
private static final int MIN_YEARS_IN_UKRAINE = 10; | ||||||
|
||||||
@Override | ||||||
public boolean test(Candidate candidate) { | ||||||
String[] splitCandidate = candidate.getPeriodsInUkr().split(SEPARATION_MARK); | ||||||
int yearsInUkr = Arrays.stream(splitCandidate) | ||||||
.map(String::trim) | ||||||
.map(Integer::parseInt) | ||||||
.reduce((a, b) -> b - a) | ||||||
.orElse(0); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we make it with substruction? |
||||||
return candidate.getAge() >= MIN_AGE | ||||||
&& candidate.isAllowedToVote() | ||||||
&& candidate.getNationality().equals(NATIONALITY) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
&& yearsInUkr >= MIN_YEARS_IN_UKRAINE; | ||||||
} | ||||||
} |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -1,80 +1,82 @@ | ||||||||
package practice; | ||||||||
|
||||||||
import java.util.Collections; | ||||||||
import java.util.Arrays; | ||||||||
import java.util.Collection; | ||||||||
import java.util.List; | ||||||||
import java.util.NoSuchElementException; | ||||||||
import java.util.function.Predicate; | ||||||||
import java.util.stream.Collectors; | ||||||||
import java.util.stream.IntStream; | ||||||||
import model.Candidate; | ||||||||
import model.Cat; | ||||||||
import model.Person; | ||||||||
|
||||||||
public class StreamPractice { | ||||||||
/** | ||||||||
* Given list of strings where each element contains 1+ numbers: | ||||||||
* input = {"5,30,100", "0,22,7", ...} | ||||||||
* return min integer value. One more thing - we're interested in even numbers. | ||||||||
* If there is no needed data throw RuntimeException with message | ||||||||
* "Can't get min value from list: < Here is our input 'numbers' >" | ||||||||
*/ | ||||||||
private static final String MIN_VALUE_NOT_FOUND = "Can't get min value from list: "; | ||||||||
private static final String AVERAGE_VALUE_NOT_FOUND = "Can't get average value from list: "; | ||||||||
|
||||||||
public int findMinEvenNumber(List<String> numbers) { | ||||||||
return 0; | ||||||||
return numbers.stream() | ||||||||
.map(split -> split.split(",")) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make constant for comma. |
||||||||
.flatMap(Arrays::stream) | ||||||||
.map(Integer::parseInt) | ||||||||
.filter(num -> num % 2 == 0) | ||||||||
.sorted() | ||||||||
.findFirst() | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
.orElseThrow(() -> new RuntimeException(MIN_VALUE_NOT_FOUND + numbers)); | ||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* Given a List of Integer numbers, | ||||||||
* return the average of all odd numbers from the list or throw NoSuchElementException. | ||||||||
* But before that subtract 1 from each element on an odd position (having the odd index). | ||||||||
*/ | ||||||||
public Double getOddNumsAverage(List<Integer> numbers) { | ||||||||
return 0D; | ||||||||
List<Integer> filterListNumbers = IntStream.range(0, numbers.size()) | ||||||||
.mapToObj(i -> i % 2 == 1 ? numbers.get(i) - 1 : numbers.get(i)) | ||||||||
.toList(); | ||||||||
return filterListNumbers.stream() | ||||||||
.filter(num -> num % 2 == 1) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's make it with one stream. |
||||||||
.mapToDouble(Integer::doubleValue) | ||||||||
.average() | ||||||||
.orElseThrow(() -> new NoSuchElementException(AVERAGE_VALUE_NOT_FOUND + numbers)); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you need to throw exception when no result found after stream execution sometimes get()/getAsDouble() may help, try to google what does it do. |
||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* Given a List of `Person` instances (having `name`, `age` and `sex` fields), | ||||||||
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), | ||||||||
* new Person(«Helen», 42, Sex.WOMAN))`, | ||||||||
* select from the List only men whose age is from `fromAge` to `toAge` inclusively. | ||||||||
* <p> | ||||||||
* Example: select men who can be recruited to army (from 18 to 27 years old inclusively). | ||||||||
*/ | ||||||||
public List<Person> selectMenByAge(List<Person> peopleList, int fromAge, int toAge) { | ||||||||
return Collections.emptyList(); | ||||||||
Predicate<Person> predicate = person -> person.getAge() >= fromAge | ||||||||
&& person.getAge() <= toAge | ||||||||
&& person.getSex() == Person.Sex.MAN; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make variables to avoid double getAge() method call |
||||||||
return peopleList.stream() | ||||||||
.filter(predicate) | ||||||||
.toList(); | ||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* Given a List of `Person` instances (having `name`, `age` and `sex` fields), | ||||||||
* for example, `Arrays.asList( new Person(«Victor», 16, Sex.MAN), | ||||||||
* new Person(«Helen», 42, Sex.WOMAN))`, | ||||||||
* select from the List only people whose age is from `fromAge` and to `maleToAge` (for men) | ||||||||
* or to `femaleToAge` (for women) inclusively. | ||||||||
* <p> | ||||||||
* Example: select people of working age | ||||||||
* (from 18 y.o. and to 60 y.o. for men and to 55 y.o. for women inclusively). | ||||||||
*/ | ||||||||
public List<Person> getWorkablePeople(int fromAge, int femaleToAge, | ||||||||
int maleToAge, List<Person> peopleList) { | ||||||||
return Collections.emptyList(); | ||||||||
Predicate<Person> personPredicate = person -> { | ||||||||
if (person.getAge() >= fromAge) { | ||||||||
if (person.getSex() == Person.Sex.WOMAN && person.getAge() <= femaleToAge) { | ||||||||
return true; | ||||||||
} | ||||||||
return person.getSex() == Person.Sex.MAN && person.getAge() <= maleToAge; | ||||||||
} | ||||||||
return false; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make variables to avoid double getAge() and getSex() methods calls |
||||||||
}; | ||||||||
return peopleList.stream() | ||||||||
.filter(personPredicate) | ||||||||
.toList(); | ||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* Given a List of `Person` instances (having `name`, `age`, `sex` and `cats` fields, | ||||||||
* and each `Cat` having a `name` and `age`), | ||||||||
* return the names of all cats whose owners are women from `femaleAge` years old inclusively. | ||||||||
*/ | ||||||||
public List<String> getCatsNames(List<Person> peopleList, int femaleAge) { | ||||||||
return Collections.emptyList(); | ||||||||
|
||||||||
return peopleList.stream() | ||||||||
.filter(women -> women.getSex() == Person.Sex.WOMAN && women.getAge() >= femaleAge) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||
.map(Person::getCats) | ||||||||
.flatMap(Collection::stream) | ||||||||
.map(Cat::getName) | ||||||||
.toList(); | ||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* Your help with a election is needed. Given list of candidates, where each element | ||||||||
* has Candidate.class type. | ||||||||
* Check which candidates are eligible to apply for president position and return their | ||||||||
* names sorted alphabetically. | ||||||||
* The requirements are: person should be older than 35 years, should be allowed to vote, | ||||||||
* have nationality - 'Ukrainian' | ||||||||
* and live in Ukraine for 10 years. For the last requirement use field periodsInUkr, | ||||||||
* which has following view: "2002-2015" | ||||||||
* We want to reuse our validation in future, so let's write our own impl of Predicate | ||||||||
* parametrized with Candidate in CandidateValidator. | ||||||||
*/ | ||||||||
public List<String> validateCandidates(List<Candidate> candidates) { | ||||||||
return Collections.emptyList(); | ||||||||
return candidates.stream() | ||||||||
.filter(new CandidateValidator()) | ||||||||
.map(Candidate::getName) | ||||||||
.sorted() | ||||||||
.collect(Collectors.toList()); | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
} | ||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Find better name.