add task solution #2916
add task solution #2916
Conversation
There was a problem hiding this comment.
Great job on implementing the task requirements! 🎉 The code is well-structured and meets the core functionality. Just a couple of minor points to consider: handle the scenario where the todo list is empty in the getNewId function, and ensure the UserInfo component renders user options correctly. Keep up the excellent work! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| Choose a user | ||
| </option> | ||
|
|
||
| <UserInfo users={usersFromServer} /> |
There was a problem hiding this comment.
The UserInfo component is used here, but it is not clear if it renders the user options correctly. Ensure that UserInfo is designed to render <option> elements for each user.
| })); | ||
|
|
||
| function getNewId(listOfTodos: Todo[]) { | ||
| const maxId = Math.max(...listOfTodos.map(todo => todo.id)); |
There was a problem hiding this comment.
The getNewId function uses Math.max on the todo IDs. If listOfTodos is empty, Math.max will return -Infinity, which will cause the new ID to be NaN. Consider handling the case where listOfTodos is empty by returning 1 as the first ID.
DEMO LINK