-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task solution #2916
Open
kovaden414
wants to merge
1
commit into
mate-academy:master
Choose a base branch
from
kovaden414:develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add task solution #2916
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,61 +1,122 @@ | ||
import './App.scss'; | ||
|
||
// import usersFromServer from './api/users'; | ||
// import todosFromServer from './api/todos'; | ||
import usersFromServer from './api/users'; | ||
import todosFromServer from './api/todos'; | ||
import { UserInfo } from './components/UserInfo'; | ||
import { TodoList } from './components/TodoList'; | ||
import { useState } from 'react'; | ||
|
||
type Todo = { | ||
id: number; | ||
title: string; | ||
userId: number; | ||
completed: boolean; | ||
}; | ||
|
||
export const App = ({}) => { | ||
const [todoList, setTodoList] = useState([...todosFromServer]); | ||
const [title, setTitle] = useState(''); | ||
const [userValue, setUserValue] = useState(0); | ||
const [inputError, setInputError] = useState(''); | ||
const [selectError, setSelectError] = useState(''); | ||
|
||
function getUserById(userId: number) { | ||
return usersFromServer.find(user => user.id === userId) || null; | ||
} | ||
|
||
const todos = todoList.map(todo => ({ | ||
...todo, | ||
user: getUserById(todo.userId), | ||
})); | ||
|
||
function getNewId(listOfTodos: Todo[]) { | ||
const maxId = Math.max(...listOfTodos.map(todo => todo.id)); | ||
|
||
return maxId + 1; | ||
} | ||
|
||
const handleInputError = (event: React.ChangeEvent<HTMLInputElement>) => { | ||
event.preventDefault(); | ||
setTitle(event.target.value); | ||
setInputError(''); | ||
}; | ||
|
||
const handleSelectError = (event: React.ChangeEvent<HTMLSelectElement>) => { | ||
event.preventDefault(); | ||
setUserValue(+event.target.value); | ||
setSelectError(''); | ||
}; | ||
|
||
const cleanForm = () => { | ||
setTitle(''); | ||
setUserValue(0); | ||
setInputError(''); | ||
setSelectError(''); | ||
}; | ||
|
||
const handleSubmit = (event: React.FormEvent) => { | ||
event.preventDefault(); | ||
|
||
const todo: Todo = { | ||
id: getNewId(todos), | ||
title: title, | ||
userId: userValue, | ||
completed: false, | ||
}; | ||
|
||
if (!title && !userValue) { | ||
setInputError('Please enter a title'); | ||
setSelectError('Please choose a user'); | ||
} else if (!title) { | ||
setInputError('Please enter a title'); | ||
} else if (!userValue) { | ||
setSelectError('Please choose a user'); | ||
} else { | ||
setTodoList([...todoList, todo]); | ||
cleanForm(); | ||
} | ||
}; | ||
|
||
export const App = () => { | ||
return ( | ||
<div className="App"> | ||
<h1>Add todo form</h1> | ||
|
||
<form action="/api/todos" method="POST"> | ||
<form action="/api/todos" method="POST" onSubmit={handleSubmit}> | ||
<div className="field"> | ||
<input type="text" data-cy="titleInput" /> | ||
<span className="error">Please enter a title</span> | ||
<label htmlFor="titleInput">Title: </label> | ||
<input | ||
type="text" | ||
data-cy="titleInput" | ||
placeholder="Enter a title" | ||
value={title} | ||
onChange={handleInputError} | ||
/> | ||
<span className="error">{inputError}</span> | ||
</div> | ||
|
||
<div className="field"> | ||
<select data-cy="userSelect"> | ||
<option value="0" disabled> | ||
<label htmlFor="userSelect">User: </label> | ||
<select | ||
data-cy="userSelect" | ||
value={userValue} | ||
onChange={handleSelectError} | ||
> | ||
<option value={0} disabled> | ||
Choose a user | ||
</option> | ||
|
||
<UserInfo users={usersFromServer} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
</select> | ||
|
||
<span className="error">Please choose a user</span> | ||
<span className="error">{selectError}</span> | ||
</div> | ||
|
||
<button type="submit" data-cy="submitButton"> | ||
Add | ||
</button> | ||
</form> | ||
|
||
<section className="TodoList"> | ||
<article data-id="1" className="TodoInfo TodoInfo--completed"> | ||
<h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
||
<a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
Leanne Graham | ||
</a> | ||
</article> | ||
|
||
<article data-id="15" className="TodoInfo TodoInfo--completed"> | ||
<h2 className="TodoInfo__title">delectus aut autem</h2> | ||
|
||
<a className="UserInfo" href="mailto:Sincere@april.biz"> | ||
Leanne Graham | ||
</a> | ||
</article> | ||
|
||
<article data-id="2" className="TodoInfo"> | ||
<h2 className="TodoInfo__title"> | ||
quis ut nam facilis et officia qui | ||
</h2> | ||
|
||
<a className="UserInfo" href="mailto:Julianne.OConner@kory.org"> | ||
Patricia Lebsack | ||
</a> | ||
</article> | ||
</section> | ||
<TodoList todos={todos} /> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,32 @@ | ||
export const TodoInfo = () => {}; | ||
import classNames from 'classnames'; | ||
|
||
type TodoInfoProps = { | ||
id: number; | ||
title: string; | ||
email: string; | ||
name: string; | ||
completed: boolean; | ||
}; | ||
|
||
export const TodoInfo = ({ | ||
id, | ||
title, | ||
email, | ||
name, | ||
completed, | ||
}: TodoInfoProps) => { | ||
return ( | ||
<article | ||
data-id={id} | ||
className={classNames('TodoInfo', { | ||
'TodoInfo--completed': completed, | ||
})} | ||
> | ||
<h2 className="TodoInfo__title">{title}</h2> | ||
|
||
<a className="UserInfo" href={`mailto:${email}`}> | ||
{name} | ||
</a> | ||
</article> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,37 @@ | ||
export const TodoList = () => {}; | ||
import { TodoInfo } from '../TodoInfo'; | ||
|
||
type Todo = { | ||
id: number; | ||
title: string; | ||
completed: boolean; | ||
userId: number; | ||
user: { | ||
id: number; | ||
name: string; | ||
username: string; | ||
email: string; | ||
} | null; | ||
}; | ||
|
||
export const TodoList = ({ todos }: { todos: Todo[] }) => { | ||
return ( | ||
<section className="TodoList"> | ||
{todos.map((todo: Todo) => { | ||
if (!todo.user) { | ||
return null; | ||
} | ||
|
||
return ( | ||
<TodoInfo | ||
id={todo.id} | ||
title={todo.title} | ||
email={todo.user.email} | ||
name={todo.user.name} | ||
completed={todo.completed} | ||
key={todo.id} | ||
/> | ||
); | ||
})} | ||
</section> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,20 @@ | ||
export const UserInfo = () => {}; | ||
type User = { | ||
id: number; | ||
name: string; | ||
username: string; | ||
email: string; | ||
}; | ||
|
||
export const UserInfo = ({ users }: { users: User[] }) => { | ||
return ( | ||
<> | ||
{users.map((user: User) => { | ||
return ( | ||
<option key={user.id} value={user.id}> | ||
{user.name} | ||
</option> | ||
); | ||
})} | ||
</> | ||
); | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
getNewId
function usesMath.max
on the todo IDs. IflistOfTodos
is empty,Math.max
will return-Infinity
, which will cause the new ID to beNaN
. Consider handling the case wherelistOfTodos
is empty by returning1
as the first ID.