Release 3.5.0 #2016
Merged
Release 3.5.0 #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Post release 3.4.1 reset
…ns from simulation namefile dfn (#1842) * feat(simulation+model options): Simulation and model file initialization parameters and attributes are now dynamically generated to include the namefile options found in the dfn file. * lint + imports --------- Co-authored-by: scottrp <45947939+scottrp@users.noreply.github.com>
* use ndarray.item() to retrieve single elements * update gridutil get_disu_kwargs() docstrings
…nd Grid.saturated_thick (#1884)
* refactor/expand tests * tidy docstrings
* describe deprecation policy loosely following NEP 23 * fix some autotest names per pending deprecations
* layer kwarg in get_data() in mfdataarray.py, 3.3.5 (June 2022) * get_mvr_file, get_mvt_file, get_gnc_file in mfsimbase.py, overdue since 3.3.6 * get_ims_package in mfsimbase.py (and update usage in mfmodel.py), overdue since 3.4
- centered_specific_discharge, 3.3.1 (June 2020) - cvfd_to_patch_collection, 3.3.4 (August 2021) - plot_cvfd, 3.3.4 (August 2021)
* use µmamba in CI tests to avoid pyzmq issue * remove pytest-virtualenv as test dependency * rewrite generate_classes tests with virtualenv * minor simplifications to autotest/conftest.py * add python 3.12 classifier to pyproject.toml * add code generation test marker to pytest.ini * add IPRN value where missing in some example input files * add pip and replace bmipy with xmipy in etc/environment.yml * deduplicate in CI workflows (consolidate windows/non-windows)
…#2005) * add testing for MfSimulationList
* fix: add missing seek to get_runtime method * too early for that assert
* fix(get_disu_kwargs): incorrect indexing of delr and delc * add vertices to the return of get_disu_kwargs * ensure nvert has proper value * handle delr/delc and ensure size is correct * isort * Modify to allow mf6 autotest to pass
* support pandas dataframe for node_data, stress_period_data etc for flopy.modflow.* pkgs * just convert to recarray, don't reimplement data storage with pandas like for mf6 * add tests with mnw and wel
* add function to return memory summary information as a dictionary * add function to return full memory table information as a dictionary
* clarify that get_kstpkper() is 0-based, kstpkper is 1-based * fix get_data() usage examples to use 0-based indices * clarify warnings and error messages
* make ipakcb docstrings consistent for all modflow (non-mf6) packages * make default ipakcb consistent (None for ipakcb=0 and no output file) * add default_cbc_unit method to Package, support ipakcb=default for 53
wpbonelli
force-pushed
the
v3.5.0
branch
2 times, most recently
from
1fd3c21 to
425c981
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2016 +/- ##
========================================
+ Coverage 69.6% 72.8% +3.1%
========================================
Files 256 259 +3
Lines 56269 59040 +2771
========================================
+ Hits 39190 43004 +3814
+ Misses 17079 16036 -1043
|
|
There were some conflicts here, fixed manually. Also trimmed some duplicates from the changelog. This was a result of not merging master back into develop after 3.4.2 and 3.4.3. In the future merging master into develop after all releases (whether hotfix or planned) should avoid repeating this and is the typical approach with the git flow AFAIK There are some extra things to mention w.r.t. deprecations and python3.12 compatibility, will add to the release notes |
langevin-usgs
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
I looked through this PR, @wpbonelli. Looks good to me. I noticed only small version number issue, which may not be an issue at all.
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| .. image:: _images/flopylogo.png | |||
|
|
|||
| **Documentation for version 3.3.7 --- release candidate** | |||
| **Documentation for version 3.5.0.dev0** | |||
There was a problem hiding this comment.
Should this have a .dev0? This is the only place I noticed it. Everything else is just 3.5.0.
There was a problem hiding this comment.
This gets updated when docs are built
Line 33 in 338f6d0
however maybe in future it would be cleaner to sub it in with everything else via scripts/update_version.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FloPy 3.5.0
The release can be approved by merging this pull request into
master. This will trigger a final job to publish the release to PyPI.