Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spelling errors and typos in Spanish #65

Closed
wants to merge 1 commit into from
Closed

Fixed spelling errors and typos in Spanish #65

wants to merge 1 commit into from

Conversation

ordtrogen
Copy link

No description provided.

@erciccione
Copy link
Contributor

@lh1008 could you review these changes please?

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 7, 2018

I'm doing a review of this.

@lh1008
Copy link

lh1008 commented Jun 7, 2018

@Josexv1 ok, I was not aware, there were no comments so I started looking at it. I did some comments in some of the translations that I noticed, in my opinion, can have a better translation. If you need any help please let me know :).

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 7, 2018

@lh1008 No problem, you can comment in my review too if you find better words to use.

Copy link

@lh1008 lh1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @erciccione, made some comments in some of them, @Josexv1 will keep on reviewing the translation. The translation needs a complete review and fix some linguistic errors. In my opinion there are some that are not correctly postulated. If you need my help just ping me, I have been a little busy these days, and I need to catch up. Thanks :), sorry for the delay.

quality: Seguros de calidad
contributing: Guía para contribuir
building: Instrucciones para compilar
faq: Preguntas frequentes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola, esta mal escrito "frecuentes :)" 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias

@@ -1,9 +1,9 @@
En adición a los contribuidores de Boost y OpenSSL, y a todos los programadores desde los tiempos inmemoriales, que han hecho este proyecto posible, queremos reconocer lo siguiente:
En adición a los contribuidores de Boost y OpenSSL y a todos los programadores desde los tiempos inmemoriales que han hecho este proyecto posible, queremos reconocer a los siguientes:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que @ordtrogen opinas de esto?

Adicional a los "colaboradores"..., o pense "contribuyente".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es posible, pero nos alejaríamos de una traducción fiel.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

En este caso, en mi opinión (puede que este equivocado), al leerlo me parece que no suena bien y al leerlo es un poco confuso. En https://www.microsoft.com/en-us/language/Search?&searchTerm=unconfirmed&langID=Spanish&Source=true&productid=All que fue una herramienta que nos proveyo @ordtrogen nos da incluso las opciones de "colaborador" o "contribuyente". Hechalo un vistazo, depronto te ayude un poco.
Para contarte un poco lo que hemos trabajado, en #monero-translations hablamos un poco sobre las traducciones "fiel" o literal. Las traducciones no se llaman monero translations sino monero localizations, precisamente para evitar traducir literal sino que mejor tenga sentido común en los diferentes lenguajes y tener en cuenta cuando un lenguaje se habla en diferentes zonas geográficas. Hemos empezado una tarea en taiga monero localization para generar unas terminologías técnicas coherentes en diferentes lenguajes para las traducciones de monero. Te invito para que nos ayudes a construirlo, es importante para los futuros contribuyentes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe a translation should strive sound as though it had been written directly in the target language, i.e you should not be able to tell it's a translation. And some rewriting / restructuring would be fine. At least in this case, a translation of a website, there aren't the same restrictions as when you're localizing a User interface.

- Wei Dai, Jeffrey Walton, y todos los desarrolladores en Cryoto++ por proveer una influencial y libre librería de criptografía en C++
- Dean Michael Berris, Glyn Matthews, y todos los desarrolladores en cpp-netlib por proveer una librería activamente desarrollada cross-plataforma de red.
- Wei Dai, Jeffrey Walton y todos los desarrolladores de Crypto++ por proveer una influencial y libre librería de criptografía en C++
- Dean Michael Berris, Glyn Matthews y todos los desarrolladores de cpp-netlib por proveer una librería activamente desarrollada cross-plataforma de red.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dean Michael Berris, Glyn Matthews, and all the developers at cpp-netlib for providing an actively developed cross-platform networking library.

Esta sería mi traducción:
"A Dean Micheal Berris, Glyn Matthews y todos los desarrolladores de cpp-netlib por proveer una biblioteca de redes (o interconectada) multiplataforma (o de plataforma cruzada) activa.


- Wei Dai, Jeffrey Walton, y todos los desarrolladores en Cryoto++ por proveer una influencial y libre librería de criptografía en C++
- Dean Michael Berris, Glyn Matthews, y todos los desarrolladores en cpp-netlib por proveer una librería activamente desarrollada cross-plataforma de red.
- Wei Dai, Jeffrey Walton y todos los desarrolladores de Crypto++ por proveer una influencial y libre librería de criptografía en C++
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wei Dai, Jeffrey Walton, and all the developers at Crypto++ for providing an influential and free C++ cryptographical library

Esta seria mi traducción:
"A Wei Dai, Jeffrey Walton y a todos los desarrolladores de Crypto++ por proveer una biblioteca criptográfica gratis e influencial en C++"

- Todos los desarrolladores involucrados en la [implementación ref10 de SUPERCOP](http://bench.cr.yp.to/supercop.html) del cual tomamos como base nuestras implementaciones Ed25519
- zzz, str4d, y todos los desarrolladores de I2P Java, en ambos, pasado y presente, que tienen un set de estándares a seguir para las demás implementaciones de I2P
- zzz, str4d y todos los desarrolladores de I2P Java, en ambos, pasado y presente, que tienen un set de estándares a seguir para las demás implementaciones de I2P
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zzz, str4d, and all Java I2P developers both past and present who have set the standard for all other I2P implementations to follow

Esta sería mi traducción:
"A zzz, str4d y a todos los desarrolladores, en ambos, pasado y presente que establecieron los estándares a seguir para las demás implementaciones de I2P.

@lh1008
Copy link

lh1008 commented Jun 7, 2018

@Josexv1 are you working in a different branch or in this same branch? Just ping me when you're done, I would love to help :).

get-started: Get Started
intro: Introduction
index: ¿Qué es Kovri?
get-started: Tareas iniciales
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Como iniciar

faq: FAQ
style: Guia de estilo
user: Guia de usuario
quality: Seguros de calidad
Copy link
Contributor

@Josexv1 Josexv1 Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Garantía de calidad o Garantías de calidad

style: Guia de estilo
user: Guia de usuario
quality: Seguros de calidad
contributing: Guía para contribuir
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "Pautas Generales"is better, you can check how Mozilla did it here: https://www.mozilla.org/es-ES/about/governance/policies/participation/ change to spanish at the bottom.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could very well be the better solution. The reason I changed it was for it to be the same as the title of a link in some of the files. Feel free to change it back and make sure the link is updated

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 7, 2018

@lh1008 i was working on a local copy of this. I'll try to update my fork so you can review it.

@lh1008
Copy link

lh1008 commented Jun 7, 2018

ok thanks.

@ordtrogen
Copy link
Author

ordtrogen commented Jun 11, 2018

Brevemente os comento que no pensé dedicarme a la traducción al Español, sino forkée el repo para traducir a mi Sueco nativo. Revisando un poco los archivos en las varias carpetas vi que faltaban bastantes tildes etc en Español, y eso es un aspecto del Español donde sí puedo contribuir algo.

Tuve la impresión de que algo le faltaba a la traducción misma, teniendo un toque "Espanglish" o algo. Pero dejo a los hispanohablantes nativos de arreglarlo.

@erciccione (and others) I'm not sure how best to proceed. Maybe if this PR could get merged so you'd get the small changes into the main repo and then you could continue the linguistic review and corrections in a separate fork?

It also appears that some files are missing from the _i18n/es directory. It contains 10 files whereas _i18n/en has 11 files

@erciccione
Copy link
Contributor

@ordtrogen It's ok for me to merge this first and then add the linguistic changes. If some files are changing you can just add them and add the 'untranslated' snippet on the top

Also, please rebase and fix the conflicts in es.yml

@ordtrogen
Copy link
Author

@erciccione So, similar to what we did yesterday?

The difference is in my clone of this project I have two branches in addition to the master branch. Should I do the rebasing on the "spanish_typos" branch (from which I PR'd) or "master" (or all branches)?

If you want to give it a try I could add you as contributor (like previously)

@erciccione
Copy link
Contributor

Yes, same as yesterday. You have to rebase from 'spanish_typos' following the same procedure of yesterday. If you find problems, yes, you can add me and i'll fix for you

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 14, 2018

I wish to know if i can take this PR as base to translate the rest of the files.

@lh1008
Copy link

lh1008 commented Jun 14, 2018

@Josexv1 speak with @ordtrogen, I believe he's also going to work in these files.

Copy link
Collaborator

@anonimal anonimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ordtrogen Thank you the PR. Note that the kovri-docs repo has changed (see the English directory) and kovri-site will have to adjust.

Resolved merge conflict by using MASTER
Copy link
Contributor

@erciccione erciccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If it's good for you @Josexv1 @lh1008 we can get it merged

@Josexv1
Copy link
Contributor

Josexv1 commented Jun 15, 2018

Looks good, and i'm using it as a base for my next PR, to me it's just the wording used that can be changed, we can discuss it on IRC to decide what words to use.

@ordtrogen
Copy link
Author

Please improve the wording ... and please put the tildes where they need to be :-)

@lh1008
Copy link

lh1008 commented Jun 15, 2018

I agree with @ordtrogen. I'll be on the #monero-es channel :) 👍

@anonimal
Copy link
Collaborator

@erciccione can you please help @ordtrogen salvage this into kovri-docs or the kovri readme? Referencing #73.

@erciccione
Copy link
Contributor

sure @anonimal , waiting for @rehrar to apply changes suggeste in #73 , then we'll help ordtrogen to move this

@Josexv1 Josexv1 mentioned this pull request Jun 30, 2018
6 tasks
@anonimal
Copy link
Collaborator

#73 was resolved. What's holding this PR?

@erciccione
Copy link
Contributor

sorry @anonimal i forgot about this one

@ordtrogen can you contact me about this when you can? those pages are now in kovri-docs and this repo got heavily updated, we need to move the changes from here to the correct files in -doc

@ordtrogen
Copy link
Author

I'm away from home atm but will look at it soon

@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS PULL REQUEST HAS BEEN MOVED TO GitLab. Please reopen there if you wish to merge. See #122 for details.

@anonimal anonimal closed this Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants