This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
RouterInfo: refactor RI writer/creator + add docs #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It's now maintainable. Allows us to finish previously unfinished development add new features such as Family Options and more - Separates/pulls-out/improves usable stream writing code (now refactored into utility code) - Adds documentation + TODO's - Related refactoring
| s.write(reinterpret_cast<char *>(ident), ident_len); | ||
| WriteToStream(s); | ||
| m_BufferLen = s.str().size(); | ||
| void RouterInfo::CreateBuffer(const PrivateKeys& private_keys) { |
There was a problem hiding this comment.
Wrong brackets style (Sorry, it was too tempting :) )
There was a problem hiding this comment.
I chose not to run clang-format on this function because it would've done more than just newline brace and, from the contributing guide:
please try to not mix formatting fixes with non-formatting commits
I'm guilty of mixing elsewhere but that's because of the amount of re-write that was involved (in those places).
If this brace bugs you enough, that can be fixed. Otherwise, I had planned on doing a complete style check-in / running clang-format on both files once RI refactoring was done.
There was a problem hiding this comment.
It was mostly for the joke
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Live tests pass. Referencing #617 #621. This WIP is in pursuit of isolating #187.
Edit: referencing #627
By submitting this pull-request, I confirm the following: