Core: router context + RI rewrite/refactor

[anonimal]

WIP as noted in #617 #621 #623 #626. Ticketing for housekeeping.

WIP in pursuit of isolating #187 (and because RI impl was in bad shape / unmaintainable).

---

By submitting this issue, I confirm the following:

• I have read and understood the contributor guide.
• I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
• I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

---

[anonimal]

Added router context because it's in just as bad shape.

[coneiric]

Small cheat-sheet for RI sizes: router_info_size.md

Some of the maximums are the max allowed by the size byte(s), when the specification doesn't otherwise limit. Should we set a cap in those cases?

[anonimal]

Cap as in capability or cap as in top/hat limit?

[anonimal]

router_info_size.md

I think this would be great in the moneropedia (see monero-site) or perhaps something in kovri-docs or kovri-site?

[coneiric]

Cap as in capability or cap as in top/hat limit?

Cap as in limit to total RouterInfo size we'll accept. Otherwise, that ~17MB max total size looks like a potential DoS vector.

I think this would be great in the moneropedia (see monero-site) or perhaps something in kovri-docs or kovri-site?

Sure, I can make a PR to monero-site and kovri-docs. Is kovri-site still pulling from kovri-docs? If not, I can make a PR there as well.

[anonimal]

Is kovri-site still pulling from kovri-docs?

Yes, it should be. This is still open though monero-project/kovri-site#73.

[anonimal]

coneiric#2

[anonimal]

coneiric#4

[anonimal]

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.