This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
RouterInfo: refactor RI reader/parser #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related refactoring + add debug logging for RI values + add TODO's
Related refactoring.
- It's now maintainable. Allows us to finish previously unfinished development - Separates/pulls out usable filestream/stream handling code from RI impl, refactored into utility code - Adds documentation + TODO's
anonimal
added a commit
that referenced
this pull request
Apr 13, 2017
5d0fc9f RouterInfo: refactor RI reader/parser (anonimal) 4582eb6 RouterInfo: initialize Address class integer members (anonimal) 77323b6 RouterInfo: add RI trait enum + getters (anonimal) c808888 StringStream: move ctor impl into source file (anonimal) 67042e1 StringStream: pass pointer to buffer when reading (anonimal) 48d1aac RouterInfo: handle if not EINVAL + handle unknown transport (anonimal)
|
Note: this WIP is in pursuit of isolating #187. |
This was referenced Apr 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Live tests pass.
Edit: referencing #627
By submitting this pull-request, I confirm the following: